CRM_Case_XMLProcessor_Process::isActivityPresent doesn't check is_deleted

[davej]

CRM_Case_XMLProcessor_Process::isActivityPresent doesn't check is_deleted. So when it's called in CRM_Case_XMLProcessor_Process::createActivity (the only place in the codebase that calls it AFAICG*) to check if max_instances of the activity type already exist, it counts activities regardless of is_deleted so skips activity creation if there are enough deleted activities.

* As Far As I Can Grep

Is this the intended behaviour?

Dave

[Dave Greenberg]

I don't think so - sounds like a bug. Can you file an issue with a patch for 3.1.2 or 3.1.3.

UPDATE: Dave D is going to take a quick look at this as well tomorrow just to verify that it's a bug.

[demeritcowboy]

Confirmed as a bug. It asks you if you want to edit the existing one and then following that link gives an error.

[davej]

Filed http://issues.civicrm.org/jira/browse/CRM-5782 .

Also CRM_Case_BAO_Case::retrieveCaseIdsByContactId doesn't check is_deleted, should it? This function doesn't seem to be used in the current codebase.

Dave J

[Dave Greenberg]

Yeah - I can't find any references to it either. I asked Yash to double check when she does the other fix.

[davej]

My vote is for keeping retrieveCaseIdsByContactId even if it isn't used in the current codebase, because given that AFAIK there are no API functions for cases, this is a really useful function. I'm currently using it in a hook. I'd rather have this function, even if it does return deleted cases, than lose it; I just wanted to clarify the intended behaviour.

Thanks,

Dave J

[Dave Greenberg]

Ok cool - I've updated the issue as follows:

"Also, update CRM_Case_BAO_Case::retrieveCaseIdsByContactId to NOT return is_deleted cases by default by adding a $includeDeleted = false parameter (which allows caller to also get deleted cases if needed)."