Incorrect membership end date with manual renewal

[Paul Jacobson]

This is my first annual membership renewal period with CiviCRM (3.1.1) and I've come across an unexpected behaviour while manually entering renewals.

I have the membership period set as fixed from Jan 1 and set to a period of 1 year.  When I manually renew with the current date renewed memberships are showing an expiry date of 31 December 2011, rather than the expected 31 December 2010.

any thoughts as to what I might be doing wrong?

cheers
Paul

[Kurund Jalmi]

Can you replicate this on http://drupal.demo.civicrm.org ?

thanks,
Kurund

[Paul Jacobson]

Hi Kurund,

Yes. I have been able to replicate the problem.  I've created a new fixed 1 year membership - "Full Member" and new member "Paul Test" and have the same issue.

I've attached a screenshot of the renewed membership showing a correct start date of 1 Jan 2010 and incorrect expiry of 31 December 2011.

cheers
Paul

[Kurund Jalmi]

Can you give details on membership, what was your start_date and end_date before / after renewing?

Kurund

[Paul Jacobson]

On my site the start date of all memberships was 1 Jan 2009 and end date 31 December 2009.  The memberships were in grace period set to 3 months. 

On the demo site I had originally created the membership with a date of 1st Feb 2008, but then edited the membership to have a start date of 1 jan 2009 and expiry of 31 december 2009.

cheers
Paul

[Paul Jacobson]

To add to the mystery I've just had a member renew via civicontribute based renewal page. With this membership the start date has not been changed from last years date and is 1 Jan 2009, while the end date is updated to correct 31 December 2010. However this is still giving a 2 year membership term instead of the 1 year fixed membership that is configured for this membership category.

cheers
Paul

[Kurund Jalmi]

Looks like a bug, hence filed: http://issues.civicrm.org/jira/browse/CRM-5795

Thanks,
Kurund

[Kiran Jagtap]

Issue is replicated for manual renew of expired membership.

fix would be part of next stable release ( CiviCRM v3.1.2 )

you might be interesting in patch : http://fisheye2.atlassian.com/changelog/CiviCRM?cs=26175

thanks

kiran

[Paul Jacobson]

Hi Kirian,

Thanks for the speedy response! I've patched my install with the above and tested with one of the remaining renewals I have to enter.

The patch appears to squash half the bug.  The end date is being updated correctly but the start date is not updated reflect the current membership year.

cheers
Paul

[Kiran Jagtap]

The end date is being updated correctly but the start date is not updated reflect the current membership year.

I have one membership record w/ dates as
Start Date =    January 1st, 2008
End Date   =    December 31st, 2008
Status       =    Expired

Now when I manual renew this membership record, New dates and status after renew are
My renew date is : February 9th 2010

Start Date =    January 1st, 2010
End Date   =    December 31st, 2010
Status       =    Current

So my start date and end date are respecting current membership year.

would be great if you provide your membership record detail or your test case scenario's.

thanks

kiran

[Paul Jacobson]

Hi Kiran

I'm keeping back a stock of renewals to troubleshoot with

The members are in a grace period - I had to change this from expired as this would have prevented them logging into renew, and the membership secretary indicated he usually gives up to 6 months grace on memberships.  It took a while to work out that the UpdateMembershipRecord.php script ignores expired members by default.

pre-update
start date = January 1st 2009
end date = December 31st 2009
Status = Grace

post-update
start date = January 1st 2009
end date = December 31st 2010
status = Current

Perhaps this is down to the grace period but start date does not respect current membership year.

cheers
Paul

[Kiran Jagtap]

hey Paul,

If I'm not wrong -

This is expected behaviour for renew grace membership record.

Logically your membership is still alive ( membership period + grace period )
so why should we need to update start date ? It is the same thing when we renew current membership.

you might want to take a closer look for  Membership Renewal Test Plan

Also It might be case UI shows grace membership status but actually that membership record is expired.
so make sure your membership record status is upto date, run bin/UpdateMembershipRecord.php cron

though membership seems to be grace two result can be possible regarding start date
1. don't update start date. ( membership really in grace period )
2. update start date. ( record actually expired )

hope this help

thanks

kiran

[Paul Jacobson]

Hi Kiran,

Thanks for the link - it does look like it's behaving as outlined, just not as I was expecting. I think I've got used to seeing start date = current year that the rollover was looking wrong.  I'm happy to call it "bug squashed".

cheers
Paul