Possible bug and fix: Maling Labels in 3.1 now prints contacts w/o adresses too

[obiuquido144]

After upgrading from 2.2.2 to 3.1.2, when we print Mailing labels, we now get all the contacts from the search printed out, not just the ones that have actual mailing adresses. In 2.2.2, contacts with e.g. only a name and email were skipped and not printed out on labels.

I did a diff on CRM\Contact\Form\Task\Label.php between 2.2.2 and 3.1.2.
A lot of code has changed, but when I replace

Code: [Select]

                foreach ( $mailingFormatProperties as $key => $dontCare ) {
                    if ( CRM_Utils_Array::value( $key, $contact ) ) {




                        $found = true;
                        break;
                    }
                }
around line 280 with

Code: [Select]

                foreach ( $sequence as $sequenceName) {
                    // we are interested in only those
                    // $contact which contains any
                    // of the address sequences
                   
                    if ( CRM_Utils_Array::value( $sequenceName, $contact ) ) {
                        $found = true;
                        break;
                    }
                }
from 2.2.2,
mailing labels start working again like they used to: contacts without postal addresses are omitted from the printout.

Not sure if this is a regression or if there's a reason for $mailingFormatProperties as $key => $dontCare now being used instead of $sequence as $sequenceName . Maybe someone with a better understanding of the code could explain better / make the decision about filing a bug for this.

Cheers! Boris

[Donald Lobo]

can you double check and ensure you can reproduce this on http://drupal.demo.civicrm.org/

if so, please file an issue along with steps to reproduce. also link to this forum topic. We'll fix in the next release

thanx

lobo

[CiviTeacher.com]

This bug is of concern to me too.

I have verified it on the Demo site and created an issue here:
http://issues.civicrm.org/jira/browse/CRM-6025