expected behavior of duplicate match processing on contrib forms

[CiviTeacher.com]

What is the expected behavior of contact matching on "in honor of" Honoree contributions, or contributions in general?  

Does the duplicate individual strict rule have anything to do with the process, or is this an incorrect assumption?

Does civicrm simply use email to match duplicates on contribution forms?  Searching the code, I cannot find an easy answer.

The reason I ask: It seems that contribution forms will match a contact based on email.  However, even if the default strict duplicate match tool is set to match on first/last, Honoree contributions will not detect a match.  

[Donald Lobo]

check:

CRM/Contribute/BAO/Contribution.php, function createHonorContact

seems like the fuzzy rule is used (not sure why)

Also i think there might be a bug in there and we'll need to add:

                $honorParams['check_permission'] = false;

to allow the entire DB to be searched. I'll check with deepak on this in a few hours

lobo

[Deepak Srivastava]

FTP: filed an issue here - http://issues.civicrm.org/jira/browse/CRM-6575.

[CiviTeacher.com]

So is duplicate checking always using the "individual fuzzy" rule?  Or does it vary by situation?

Can someone provide some insight as to when the "strict" rule and "fuzzy" rules are used by Civicrm for duplication checking on form submit?

[Dave Greenberg]

The convention is that the default STRICT rule is used for matching for public facing forms (e.g. online contribution pages, online registration, create profiles) AND for "unattended" batch operations (e.g. Import). The default FUZZY rule is used for attended back-office forms where we can give the user a heads up that there is a potential duplicate and they can decide what to do about it (e.g. Add / Edit Contact, create new contact while adding contribution, case etc.).

If there are exceptions to this, they are bugs IMO.
HTH

[CiviTeacher.com]

the In Honor/In Memory uses the Fuzzy rule according to Lobo.  Interesting.  That's why I was so confused, because like you I thought the strict rule was the one used for public facing form.s  thanks

[Donald Lobo]

can u file an issue and we'll take a look and fix for 3.3 / 3.2.x

thanx

lobo

[CiviTeacher.com]

done

[Donald Lobo]

hey stoob:

can u please check this patch and see if it works for you:

Code: [Select]

Index: CRM/Contribute/BAO/Contribution.php
===================================================================
--- CRM/Contribute/BAO/Contribution.php (revision 29050)
+++ CRM/Contribute/BAO/Contribution.php (working copy)
@@ -735,19 +735,21 @@
                               'last_name'     => $params["honor_last_name"],
                               'prefix_id'     => $params["honor_prefix_id"],
                               'email-Primary' => $params["honor_email"] );
-        if ( !$honorId ) {
-            require_once "CRM/Core/BAO/UFGroup.php";
+        if ( ! $honorId ) {
             $honorParams['email'] = $params["honor_email"];
-            $honorParams['check_permission'] = false;
-            $ids = CRM_Core_BAO_UFGroup::findContact( $honorParams, null, 'Individual' );
-            $contactsIds = explode( ',', $ids );
-           
-            if ( is_numeric( $contactsIds[0] ) && count ( $contactsIds ) ==  1 ) {
-                $honorId = $contactsIds[0];
-            }
+
+            require_once 'CRM/Dedupe/Finder.php';
+            $dedupeParams = CRM_Dedupe_Finder::formatParams($honorParams, 'Individual');
+            $dedupeParams['check_permission'] = false;
+            $ids = CRM_Dedupe_Finder::dupesByParams($dedupeParams, 'Individual');
+
+            // if we find more than one contact, use the first one
+            $honorId  = CRM_Utils_Array::value( 0, $ids );
         }
         
-        $contact =& CRM_Contact_BAO_Contact::createProfileContact( $honorParams, CRM_Core_DAO::$_nullArray, $honorId );
+        $contact =& CRM_Contact_BAO_Contact::createProfileContact( $honorParams,
+                                                                   CRM_Core_DAO::$_nullArray,
+                                                                   $honorId );
         return $contact;
     }