Possible bug in CRM_Core_BAO_CustomGroup::formatCustomValues

[dpolant]

On one of our sites, some custom data was not showing up on the summary tab of the user contact page. I stepped through the code and found the problem inside CRM_Core_BAO_CustomGroup::formatCustomValues.

Code: [Select]

       
case 'Money':
            if ($htmlType == 'Text') {
                require_once 'CRM/Utils/Money.php';
                $retValue = CRM_Utils_Money::format($value, null, '%a');
                break;
            }

I have a money field that is a radio group. When I comment out the conditional here, the data gets loaded into smarty and displayed correctly. Additionally, I looked further down the page at the default: case. This searches the $customValue array for a match with the permitted set of options. I think this is where the radio button case is supposed to be handled. However it is failing to find a match when it is comparing my radio group because one of the sides is not converted to money format in the comparison.

I attached a patch that seems to solve the problem. I'm posting this in the forums before I add it as an issue. Patch is a .txt so that the uploader will allow it.

[Erik Hommel]

Thanks, appreciated!