Problem renewing an expired Membership which is Annual, fixed start date.

[damion]

For others who may run into this; as well this should become a patch if I'm right that its a bug.

I believe I've isolated a problem with the calculation of start date for a new membership being generated as a result of a user renewing an expired membership WHEN start date of annual memberships is not Jan 1 (which test plan does test for). 

Our renewal date is Oct 1.  Our expired user hadn't renewed from previous October.  They just tried on Jan 11, 2011 to renew.  In summary, the year that was calculated for new membership start date was 2011 (the current year), hence new account was to be Oct 1, 2011.  This PREVENTS creation of new membership since NO membership status is matched, when I think the system needs at least a membership like "Current" to match.  Start date is supposed to be Oct 1, 2010 , and that does match to "Current" membership.  I applied fix below, and renewals started working again. 

The problem isn't exposed with a January 1 start date which I think may be the only annual membership date checked for in Test plan:  http://wiki.civicrm.org/confluence/display/CRM/Test+Plan+-+Membership+Renewal?showComments=true&showCommentArea=true#addcomment

In our code I put in a fix to this:


Problem exists at line 523 of :
/var/www/vhosts/beta.bcsot.org/httpdocs/cms/sites/all/modules/civicrm/CRM/Member/BAO/MembershipStatus.php
 
 
                #Jan 11 2011: CUSTOMIZATION of   $yearValue = date( 'Y' );
                #Note, rollover date should still work.  After rollover date is passed in current year, year will be advanced by 1 year.
                $yearValue = date( 'Y' )-1;