We miss a hook, or the post hook is not at the right place?

[xavier]

Hi,

Right now, the pre/post hooks are strongly bound with the interface and that's only when you modify the Entity through the web interface that they are fired.

eg. if you modify a group, add a tag or create a contact via the API, you can't modify the behaviour.

The post hook is fired from the form,
http://wiki.civicrm.org/confluence/display/CRMDOC33/CiviCRM+hook+specification#CiviCRMhookspecification-hookcivicrmpost


I'd like to be able to alter the DAO object before and after the call. It seems to be enough to plug the call into the  function save of the DAO.

1) Does it make sense ?

2) Is calling a hook costly ? In that case, might be better to skip the pre and only do the post ?

3) Are we mostly sure that every modification/creation goes thought a save()? (happy to ignore the modules that write directly into the db)

X+

[Erik Hommel]

It makes sense to have some way to add customized processing before and after a DB update?

[xavier]

@lobo

THe problem is that the post hook is NOT in the DAO, but in the form:

CRM/Core/Form.php:        CRM_Utils_Hook::postProcess( get_class( $this ),

Can we introduce these hooks ?

X+

[Donald Lobo]

xavier:

the post hook is different from the postProcess hook

for most objects where the post hook is implemented, all create/update of that object in the db, goes thru the same BAO function (typically create or add)

lobo

[xavier]

My bad, never feed a grep after midnight

So that's what I can find. I don't understand how that's called for the other entities. To be sure it's always called, shouldn't we move it to the DAO ?

CRM/Core/BAO/Tag.php:            CRM_Utils_Hook::post( 'delete', 'Tag', $id, $tag );
CRM/Core/BAO/Tag.php:            CRM_Utils_Hook::post( 'edit', 'Tag', $tag->id, $tag );
CRM/Core/BAO/Tag.php:            CRM_Utils_Hook::post( 'create', 'Tag', null, $tag );
CRM/Core/BAO/EntityTag.php:        CRM_Utils_Hook::post('create', 'EntityTag', $tagId, $object );
CRM/Core/BAO/EntityTag.php:        CRM_Utils_Hook::post( 'delete', 'EntityTag', $tagId, $object );
...


I'm asking because CaseActivity doesn't trigger the hook call, I'm assuming that's a bug, I'll fill an issue.

[Donald Lobo]

Not all entities call the hook and we need to add code to make it do so

so, adding it to the DAO is a move in the right direction. maybe a project for 4.1

lobo