Making it easy to test

[Eileen]

I have just switched across to branch 3.4 & trying to run my first test (to make sure a problem I have fixed is tested) and I find it fatals on not being able to find civicrm.settings.php. So, I remove the .txt extension & run again

I couldn't at first think of a good reason since you would almost always just rename it. But I guess there might be circumstances when people would want to change the db name so it might make more sense to ship it with the php extension but have something like

if (file_exists('settings.local.php'){
include 'settings.local.php';
}

[xavier]

I thought the name of the db was hardcoded ? (and in that case, what's the purpose of needing the setting file indeed)

What I never quite understood was why the name of the db is hardcoded, but login/pwd/host have to be put as a parameter when you run the test suite. Me would be happy if it takes the default (eg. test/test or what's in the suggested settings.local.php) when not in the url.


X+

[Michał Mach]

Eileen: To be sincere, as we move forward with improving the suite, there is less and less reason for separate civicrm.settings.php just for tests. As the suite developed, we started setting things on runtime and not in settings file. So I would say it's a legacy things right now. On the other hand, setting up test suite is not a daily task and it's mentioned in documentation as one of the first steps... :-) (http://wiki.civicrm.org/confluence/display/CRM/Setting+up+your+personal+testing+sandbox+HOWTO).

When we get to improving the suite infrastructure, I think I would like to spend time on upgrading PHPunit to newer version and/or making our tests run off pristine PHPunit (now we used slightly hacked version) - and that would be a good moment to get rid of this thingy.

Xavier: Hardcoded db name is a feature created especially for you, so you don't have to write: "What I never quite understood was why my sandbox database is being overwritten with blank db, removing all my profiles and other stuff". :-)

Thx,
m

[xavier]

Xavier: Hardcoded db name is a feature created especially for you, so you don't have to write: "What I never quite understood was why my sandbox database is being overwritten with blank db, removing all my profiles and other stuff". :-)

Yeap, me like it hard and coded too. was suggesting to do the same with the login & password.

[Eileen]

Code: [Select]

On the other hand, setting up test suite is not a daily task
No, but I spent the time I was going to spend on writing an extra test on getting my test suite re-jigged.

NB, I did realise there are 2 things in the civicrm.settings.php file:

1) the temp path/ smarty template path - I assume there is a way to get the system variable for this that works across machines

2)    define( 'DOCUMENT_ME' ,1); which causes the examples to be generated.
I think I should reverse this so you can turn it off since otherwise there is the danger that no-one except me ever does it & you all hate my windows line breaks (and of course if it isn't useful enough to go beyond just me it should be ditched). I'm referring to the examples in

http://svn.civicrm.org/civicrm/trunk/api/v3/examples

[Michał Mach]

NB, I did realise there are 2 things in the civicrm.settings.php file:

1) the temp path/ smarty template path - I assume there is a way to get the system variable for this that works across machines

2)    define( 'DOCUMENT_ME' ,1); which causes the examples to be generated.
I think I should reverse this so you can turn it off since otherwise there is the danger that no-one except me ever does it & you all hate my windows line breaks (and of course if it isn't useful enough to go beyond just me it should be ditched). I'm referring to the examples in

http://svn.civicrm.org/civicrm/trunk/api/v3/examples

Not sure I follow here. You want that to be added to testing settings?

m

[Michał Mach]

Xavier: Hardcoded db name is a feature created especially for you, so you don't have to write: "What I never quite understood was why my sandbox database is being overwritten with blank db, removing all my profiles and other stuff". :-)

Yeap, me like it hard and coded too. was suggesting to do the same with the login & password.

Cool, send me the patch. ;-)

m

[Eileen]

I think it would be good if the smarty path defaulted to the system temp path

re document_me - I can reverse it in class CiviUnitTestCase

function documentMe($params,$result,$function,$filename){

from

 

Code: [Select]

      if(DOCUMENT_ME ==1){

       
       if ( file_exists('../tests/templates/documentFunction.tpl')) {
          $f = fopen("../api/v3/examples/$entity$entityAction.php", "w");
          fwrite($f,$smarty->fetch('../tests/templates/documentFunction.tpl'));
          fclose($f);
        }
        }

 

Code: [Select]

      if(!DOCUMENT_ME ==1){

       
       if ( file_exists('../tests/templates/documentFunction.tpl')) {
          $f = fopen("../api/v3/examples/$entity$entityAction.php", "w");
          fwrite($f,$smarty->fetch('../tests/templates/documentFunction.tpl'));
          fclose($f);
        }
        }

[Michał Mach]

Eileen,

Let's catch up on IRC. :-)

m