multiple membership signup pages and "upsell"

[mclyde]

On my test site, I have two different membership sign-up pages:  one for the primary membership and the other for a section.  The section and  primary membership types are configured to have different organizations and contribution pages.   If I have an existing primary membership, and then sign-up for a  section membership through its civiContribute page, the "upsell" feature in civicrm 3.4.1 overwrites the existing membership type, rather than adding a new record for the second "organization".   Thus a contact can have at most one membership active at a time.

If I add a second membership (backend), then go to the membership signup pages, the correct end dates are shown for both (so it is seeing both membership records), but the renewal is always updating the first record.

While membershipTypes are within an organizations, Contribution pages apparently can have a mix of organizations.

The membership self- renewal and backoffice add/renew membership seem to have different actions in this case.

One solution is to have contribution pages be specific to an organization and only allow membership types within that organization, and then restrict upsell within an organization to allow a contact to have multipl memberships

[Dave Greenberg]

If the 'section' membership type is associated with a different Organization record from the 'primary' type - then one should not "overwrite" the other. Only membership types linked to the same organization s/b affected by "upsell" (and the result of signing up for 'section' should be creation of a second membership).  Would be helpful if you could recreate your setup and this behavior on the public demo, and then post back here w/ steps to replicate the behavior.

[mclyde]

Dave,

I get the same behaviour on the sandbox site:

primary organization  name ISBA  (contribution page id=4) with one membership type  ISBA Regular Membership

section organization name OB/ISBA  (contribution page id=5) with one membership type

demo purchases primary membership, using contribution page ISBA Dues
http://sandbox.civicrm.org/en/civicrm/contribute/transact?reset=1&id=4

looks fine as a new member

demo then goes to section contribution page
http://sandbox.civicrm.org/en/civicrm/contribute/transact?reset=1&id=5
and purchases a sectin membership

Checking under the membership tab, there is one membership record not 2 as one would hope.  It is  partially overwritten by buying the section membership (which is labeled as a renewal).  Some fields are updated, but not source, for example.
Both contributions are linked to the one membership

 I couldn't see where in the renewMembership function that it restricts the upsell feature to memberships within an organization.   

(edited for clarity)

[joe murray]

mclyde: I've created an issue for this undesired behaviour: http://issues.civicrm.org/jira/browse/CRM-8141

Could you review and post a comment on the issue if it is inaccurate / incomplete. I don't think I'll be able to post a patch in the next day or two, so the fix won't make the x.x.2 release that is imminent. If you follow the issue then you'll find out when I post the patch and you should be able to apply it to your installation before the x.x.3 release if you need it asap.

[mclyde]

Ji Joe,

that summary seems accurate.

While I envision setting up membership signup pages that would be restricted to only one organization, the civi Membership block on the contribution pages allows one to choose any combination of membership types  regardless of the organization.   

(I have been trying to sort out how I want to represent the memberships that our joint with our sister organization in light of upsell, so should the membership type belong to the same organization or a different on the same signup page.   With the proposed fix I would need to have them be under the primary organization in order to have the right renewal dates, I believe. 

[mclyde]

BTW this affects 3.4.1 (in addition to 4.0.1) if that matters

[JoeMurray]

okay, I will create fix for the 3.4 branch.

[mclyde]

Any idea of when a patch will be ready so that we can maintain multiple signup pages within one site?

(I have  a   code snippet for renewing with upsell/muplt org written with mainly api calls posted http://forum.civicrm.org/index.php?topic=20050.0) 
this is for with the ubercart module and it seems to give the right results, but is much shorter than the core function, so not sure that it does do all of the right actions :-)

 In any cse I would like to have a user be able to use either the ubercart page,  the civiContribute page(s) or back-office code to renew.

Thanks!
Merlise

[JoeMurray]

Hopefully by Tuesday, June 7, 2011.

[mclyde]

Joe,

I saw your update on JIRA and that this won;t  be released before 3.4.5..  Any more updates on timeline for when that will be ready or if a patch for 3.4.4 will be available earlier? 

Thanks!
Merlise