add name index to civicrm_currency?

[Eileen]

I noticed devel reporting this as a slow query (when I run the pledge summary report) - perhaps we should add an index on name?

SELECT id, name FROM civicrm_currency ORDER BY name

[xavier]

Why is this searching by name in the first place (there isn't anywhere you can type the currency, that's always selected from list we generate, isn't it?)

X+

[Donald Lobo]

I suspect this is used by default to load the currencies into the pseudo-constant memory cache. Not sure why its called in the pledge summary report. Might be an extraneous call.

BUT adding an index on NAME might not be a bad idea since if we do want any details of the currecy (symbol?) we'll refer to the currency by its name (USD, SEK, EUR) etc

lobo

[Eileen]

The only think I can see that could be calling it is

                              array( 'title'     => ts('Pledge Amount'),
                                     'required'  => true,
                                     'type'      => CRM_Utils_Type::T_MONEY ),

So, if it's missing a call to  a pseudoconstant it's happening from somewhere more integral than Civi that the pledge report

[Eileen]

Actually I think that query only ran once so it might hae been the pseudoconstant call - it just came up as slow rather than repetitive (the repetitive ones are a bigger issue but it's probably worth adding the index - I'll log an issue)