validate hook possibly broken?

[lcdweb]

i'm using the validate hook on CRM_Contact_Form_Relationship and it doesn't appear to be working --
when I construct and return the errors array, it still validates.
as a workaround, I can set an error with the form object: $form->setElementError('field', 'message');

but the documented usage appears to be broken -- at least on this form.

[Donald Lobo]

I tried this and it worked (on v3.4)

Code: [Select]

function civicrm_civicrm_validate( $formName, &$fields, &$files, &$form ) {
    if ( $formName == 'CRM_Contact_Form_Relationship' &&
         CRM_Utils_Array::value( '_qf_Relationship_refresh', $fields ) !== 'Search' ) {
        $errors = array( 'relationship_type_id' => 'You will never get past this');
        return $errors;
    }
}

lobo

[lcdweb]

i dropped the same exact code into 4.0.8 and it didn't work.
i can echo inside the condition and confirm that it's getting there. but returning the errors array doesn't do anything.

[lcdweb]

Lobo -- did more testing and the bug seems to be limited to J16+/C4
I tested on D7+trunk, J15+C3.4 and J16+C4, and it worked on all but the J16+C4
very strange. maybe there's a name conflict or something?

[lcdweb]

confirmed with Lobo that it is a bug.
issue filed here: http://issues.civicrm.org/jira/browse/CRM-9395