Error when real time money transfers not used

[msn]

CiviCRM 4.1 beta 1

On the thank you page after making a member (civicrm/contribute/transact?_qf_ThankYou_display=true&qfKey=65d09f33ca5c4921de1a1c8d6f870c16_6080) I have a few errors.

Code: [Select]

    Notice: Undefined index: billing_first_name in CRM_Contribute_BAO_Contribution::createAddress() (regel 1082 van /home/public_html/drupal-7/sites/all/modules/civicrm/CRM/Contribute/BAO/Contribution.php).
    Notice: Undefined index: billing_middle_name in CRM_Contribute_BAO_Contribution::createAddress() (regel 1082 van /home/public_html/drupal-7/sites/all/modules/civicrm/CRM/Contribute/BAO/Contribution.php).
    Notice: Undefined index: billing_last_name in CRM_Contribute_BAO_Contribution::createAddress() (regel 1082 van /home/public_html/drupal-7/sites/all/modules/civicrm/CRM/Contribute/BAO/Contribution.php).
    Notice: Undefined index: billing_street_address-5 in CRM_Contribute_BAO_Contribution::createAddress() (regel 1085 van /home/public_html/drupal-7/sites/all/modules/civicrm/CRM/Contribute/BAO/Contribution.php).
    Notice: Undefined index: billing_city-5 in CRM_Contribute_BAO_Contribution::createAddress() (regel 1085 van /home/public_html/drupal-7/sites/all/modules/civicrm/CRM/Contribute/BAO/Contribution.php).
    Notice: Undefined index: billing_state_province_id-5 in CRM_Contribute_BAO_Contribution::createAddress() (regel 1085 van /home/public_html/drupal-7/sites/all/modules/civicrm/CRM/Contribute/BAO/Contribution.php).
    Notice: Undefined index: billing_postal_code-5 in CRM_Contribute_BAO_Contribution::createAddress() (regel 1085 van /home/public_html/drupal-7/sites/all/modules/civicrm/CRM/Contribute/BAO/Contribution.php).
    Notice: Undefined index: billing_country_id-5 in CRM_Contribute_BAO_Contribution::createAddress() (regel 1085 van /home/public_html/drupal-7/sites/all/modules/civicrm/CRM/Contribute/BAO/Contribution.php).
Looks similar to http://forum.civicrm.org/index.php?topic=21889.0

Found that the errors only apear when the contributions amount "Execute real-time monetary transactions"  in the contribution page is not used. Page civicrm/admin/contribute/amount?action=update&reset=1&id=1

Is there another way to switch off the real time money transfers (without payment processor) and as a default use the pay later function. I only want to send the bill to the billing post-adress or billing email

[Kurund Jalmi]

Is there another way to switch off the real time money transfers (without payment processor) and as a default use the pay later function. I only want to send the bill to the billing post-adress or billing email

You should test this with Dummy Processor

Kurund

[msn]

Thanks for the respond.

I did test it with dummy processor, that works. That is not the problem. But I don't need a payment processor.

The problem is when you don't use a payment processor,  when you dont't use real time money transfers in the contribution page, a lot of errors are generated.

In the contribution page there is the option to switch on or off the real time money transfer. Switching it off is needed when real time credit card payments are not needed. A dummy is nice for testing, the errors are gone, not for a life situation.

[Kurund Jalmi]

Oh sorry I kind of misunderstood your requirement.

Check your contribution page settings >> Contribution Amounts

and uncheck Execute real-time monetary transactions checkbox.

Hth
Kurund

[msn]

"and uncheck Execute real-time monetary transactions checkbox."

That is what I do, and now, on the thank you page, after making a member, there are those errors.

[Kurund Jalmi]

Can you try below patch:


Index: CRM/Contribute/Form/Contribution/Confirm.php
===================================================================
--- CRM/Contribute/Form/Contribution/Confirm.php        (revision 38091)
+++ CRM/Contribute/Form/Contribution/Confirm.php        (working copy)
@@ -1065,7 +1065,9 @@
         require_once 'CRM/Contribute/BAO/Contribution.php';
         
         //create an contribution address
-        if ( $form->_contributeMode != 'notify' && !CRM_Utils_Array::value('is_pay_later', $params) ) { 
+        if ( $form->_contributeMode != 'notify'
+            && !CRM_Utils_Array::value('is_pay_later', $params)
+            && CRM_Utils_Array::value( 'is_monetary', $form->_values ) ) {
             $contribParams['address_id']  = CRM_Contribute_BAO_Contribution::createAddress( $params, $form->_bltID );
         }


Kurund

[msn]

YES, this helps. I made a member and the errors are gone.

Thanks

[Kurund Jalmi]

ok kool, fix will be part of next 4.1 beta

Kurund

[msn]

I dont know, maybe this is more a feature request for a "pay later" function:

With the Execute real-time monetary transactions checkbox unchecked, the payment processor is switched off. The pay later checkbox still works, it shows itself in the "make me a member account form" (civicrm/contribute/transact?reset=1&id=1) as default setting. That is perfect!

Three things with this settings to make a member with only the pay later option.

First
When making a member contribution with:
    Execute real-time monetary transactions checkbox = off
    Pay later checkbox = on
the status of the payment transaction ends with "completed". That is not correct, we are making a pay later transaction, pending (pay later) is the correct status, I assume.

Second
The field "instruction to pay later" is not shown in the  "make me a member account form" (civicrm/contribute/transact?reset=1&id=1)
I did see this text on the thank you page.

Third
The menu tab contribute is not "highlighted" (status on), probably because the execute real-time monetary transactions checkbox
is the master switch for that. But contribute is used with a pay later setup.

[msn]

I did some more testing.

With
    execute real-time monetary transactions checkbox checked and
    no provider selected
the member transaction ends in a pending state.  GOOD!
That makes point  one perfect workable.

[Kurund Jalmi]

First
When making a member contribution with:
    Execute real-time monetary transactions checkbox = off
    Pay later checkbox = on
the status of the payment transaction ends with "completed". That is not correct, we are making a pay later transaction, pending (pay later) is the correct status, I assume.

This is more of a regression bug, please file an issue for this.

Third
The menu tab contribute is not "highlighted" (status on), probably because the execute real-time monetary transactions checkbox
is the master switch for that. But contribute is used with a pay later setup.

Yes, flag is on monetary transactions checkbox, so it is expected behavior.

Kurund