4.1b3 - Issues with Event shortcodes

[anthonycamilleri]

Dear all,

A couple of issues still exist with the event shortcodes, which are destroying the flow of the site:

1. When directed to an error page, the page reverts to /index.php?page=Civicrm instead of staying on the shortcode link, destroying appropriate formatting.

2. The default 'Thank You' Page template directs the user back to the page at the default address instead of the new shortcode address.

Anthony

[anthonycamilleri]

Small addtional note: I have been unable to figure out how to change this in the code myself - but am more than willing to test any code samples on my installation to help.

[anthonycamilleri]

Dear all,

I don't mean to pedantic - but does anyone have a suggested resolution on  this?

Anthony

[Donald Lobo]

No

But can you post an issue on: http://issues.civicrm.org/ with this info. Also point to this forum topic

hopefully someone from the community will take a look at it and/or once of us will take a look at it when we are a bit less slammed

lobo

[Donald Lobo]

1. I could not reproduce this locally. On errors, it came back to the same page with the errors displayed

2. I dont understand what you mean by this. Can you elaborate / explain in a different way

thanx

lobo

[anthonycamilleri]

Dear Lobo,

I will try and explain the shortcode issue better, using live examples from my websites. I have managed to reproduce this error on two different installations, using both permalinks and standard-links, and both for the events and contribution pages.

Event Page with Pretty Permalinks enabled
1. My event registration form is at: http://www.eurashe.eu/ac2012-reg/. As you can see 'ac2012-reg' is the civicrm page with the shortcode installed.
2. If you leave the form blank and click 'continue', so as to generate an error, you are taken to http://www.eurashe.eu/index.php?page=CiviCRM&q=civicrm/event/register
3. The page you should actually have been taken to, so as to keep the page template and structure in order is http://www.eurashe.eu/ac2012-reg?page=CiviCRM&q=civicrm/event/register

Contribution Page without Pretty Permalinks enabled
1. My signup form is at: http://crm.efquel.org/?page_id=4. As you can see '?page_id=4' is the civicrm page with the shortcode installed.
2. If you leave the form blank and click 'confirm contribution', so as to generate an error, you are taken to http://crm.efquel.org/index.php?page=CiviCRM&q=civicrm/contribute/transact&page_id=4
3. I'm not sure the exact URL formation in this combination, but again you have been redirected to a page which is nested under 'index.php' instead of under '?page_id=4' from a templating perspective.

I have registered a bug in the issue tracker to help - hope this explanation is easier to follow.

[anthonycamilleri]

In terms of the second issue:

The file templates/CRM/Event/Form/Registration/ThankYou.tpl contains teh following code:

Code: [Select]

   <div class="action-link section event_info_link-section">
        <a href="{crmURL p='civicrm/event/info' q="reset=1&id=`$event.id`"}">&raquo; {ts 1=$event.event_title}Back to "%1" event information{/ts}</a>
    </div>
The code is intended to send you back to the event page. However, as currently written, it sends you back to the 'default' event page, instead of the 'shortcode' event page.

Hope this is clearer. I also registered a bug report.

Anthony

[Donald Lobo]

I will try and explain the shortcode issue better, using live examples from my websites. I have managed to reproduce this error on two different installations, using both permalinks and standard-links, and both for the events and contribution pages.

can you please reproduce this on our sandbox server:

http://sandbox.wordpress.civicrm.org/

thanx

lobo

[anthonycamilleri]

Hi Lobo,

After some extra testing on the sandbox, I have found that with default permalinks settings, the shortcode-error page works fine. The problem crops up, if you choose any of the other options under 'Settings > Permalinks' in a default WP install. (this is an extremely common configuration option).

I don't have access to change those settings on your test install, but if you would be so kind as to switch to the setting, I can easily reproduce the error on sandbox.

Thanks for all the support.

Anthony

[Donald Lobo]

for 4.1 we'll support only the default permanlink setting. maybe in a future version someone from the WP community will contribute code that supports the other options

lobo

[Donald Lobo]

Code: [Select]

   <div class="action-link section event_info_link-section">
        <a href="{crmURL p='civicrm/event/info' q="reset=1&id=`$event.id`"}">&raquo; {ts 1=$event.event_title}Back to "%1" event information{/ts}</a>
    </div>

is this issue also related to the permalink setting being changed from the default setting?

lobo

[anthonycamilleri]

Hi, yes, it is also related to the permalink setting. After a few hours of trying to figure it out, I have posted a fix in the issues tracker, which fully solves the issue.

[Donald Lobo]

cool thanx.

there was one error, in which u referenced an unknown variable: $post. I eliminated that reference in the patch

ping me on IRC if u have any questions. thanx for taking a look and patching, much appreciated

lobo

[anthonycamilleri]

I tried the modification without $post - it breaks the functionality of the edit again. $post is one of the standard wordpress variables, therefore I believe it is included through the 'require' statements.

[Donald Lobo]

can u apply this patch and check if it works:

Code: [Select]

Index: CRM/Utils/System/WordPress.php
===================================================================
--- CRM/Utils/System/WordPress.php      (revision 38787)
+++ CRM/Utils/System/WordPress.php      (working copy)
@@ -185,7 +185,8 @@
 
         if ( $config->userFrameworkFrontend ) {
             if ( get_option('permalink_structure') != '' ) {
-                $script = get_permalink( );
+                global $post;
+                $script = get_permalink( $post->ID );
             } else {
                 $script = 'index.php';
             }

thanx

lobo