Issues for the Sagepay Payment Extension

[andyw]

I see - well thanks very much for looking into that and providing a fix - I will put your changes in, get a new version released.

@Generic, did you ever submit that patch of yours to core? If not, might be worth doing that and getting that fixed in future versions, so people don't have to manually patch. Can give you a hand with doing that if you want, just drop me an email or PM or something.

[Generic]

Hi Andy

I can't remember if I submitted it or not but I think from what Denitz is saying is that he fixed the same issue without my patch.

I have a stock install running locally that I will test his patch without mine and report back.

[Dan C]

The patch does not appear to be part of core.  So if you find it is still necessary it should be submitted.  If it doesn't, great!

[Generic]

I'm not sure what has been fixed with Denitz patch.

The forward slashes can be escaped or un-escaped I think this was something Sagepay use to require.
Adding test=1/0 is achieving what? CiviCRM knows if a test/test drive is being run from within the admin area and as a result it doesn't include the record as a valid submission.

With or without Denitz patch the homepage is still returned unless the Session.php patch is applied.

[Dan C]

Ok, sounds like we need to get the patch merged into Core.  Can you open a bug ticket and link it here, I will try to enter a PR a little later.

[Tony Horrocks]

I'm getting this CiviCRM file missng error and I cannot see where to get this file online

SagePayServer.php

Can anyone help?

[Tony Horrocks]

In case anyone else has the problem I had here, make sure you delete any older versions of the sagepay processor from the civicrm_processors table.

[Tony Horrocks]

I've got SagePay working but I'm not seeing it working when trying to renew memberships offline. It is not available to me a s payment processor.

So for example when someone wants to renew a membership I cannot select SagePay to process the payment details. Is that a bug or have I configured something incorrectly? Thanks

[zangxuma]

i think visit

https://civicrm.org/extensions/stripe-payment-processor

[it-support]

Sagepay has just sent us a reminder that the deadline for moving to version 3.0 of their VPS protocol is in 4 months and this extension is still using 2.23 so do we know what the timeline for this to be updated? (Sagepay documentation on this change: http://sagepay-email.com/8Z4-3BHF0-68PRDF-1K12O9-1/c.aspx )

[Denitz]

New details about Civicrm - Joomla integration: Server error 5006: Unable to redirect to Vendor's web site. The Vendor failed to provide a RedirectionURL.  error for recent Sagepay processor 3.1.0:

We started to receive this error in civicrm 4.4.7

The problem is that Sagepay POSTs IPN data, there is no current session since it's new request - and /components/com_civicrm/civicrm.php redirects IPN call to homepage:

Code: [Select]

function civicrm_invoke() {
  civicrm_initialize();

  // check and ensure that we have a valid session
  if (!empty($_POST)) {
    // the session should not be empty
    // however for standalone forms, it will not have any CiviCRM variables in the
    // session either, so dont check for it
    if (count($_SESSION) <= 1) {
      $config = CRM_Core_Config::singleton();
      CRM_Utils_System::redirect($config->userFrameworkBaseURL);
    }
  }
Actually it's civicrm for Joomla issue - but anyway - I guess this explanation will help somebody.

The solution is to create a system Joomla plugin which auto-populates $_SESSION, so next redirect doesn't occur.

Code: [Select]

<?php
defined('_JEXEC') or die;

// Fix Civicrm Sagepay IPN bug in /components/com_civicrm/civicrm.php - it redirects to homepage on POST with new session!
if (!empty($_POST) && count($_SESSION) <= 1)
{
    $_SESSION['dummy1'] = 1;
    $_SESSION['dummy2'] = 1;
}

Reported on https://github.com/circleinteractive/uk.co.circleinteractive.payment.sagepay/issues/10 - may be smbd will find it useful.

[Denitz]

Actually it can be related to recent Joomla security patches and we really have only single $_SESSION key now:
https://docs.joomla.org/J3.x:Backward_Compatibility_in_Joomla_3.4.7

[jamessmall]

Hi guys.

I'm having no joy installing the Sagepay Payment Processor from inside Civi.

When I click Download and install I get the following errors:

Unable to extract the extension: bad directory structure

Extension Upgrade Failed
Download failed - ZIP file is unavailable or malformed

I have successfully installed other extensions.

Anyone able to help?

Thanks
James

[Denitz]

I have already emailed the author about this issue but didn't get any response yet.

The problem is that civi requires the root folder (folder from extension zip) name exactly same as extensions name:

Code: [Select]

/uk.co.circleinteractive.payment.sagepay
While the auto-downloaded file http://extensions.circle-interactive.co.uk/uk.co.circleinteractive.payment.sagepay-v3.1.0.zip has

Code: [Select]

/uk.co.circleinteractive.payment.sagepay-v.3.1.0
So the extract fails.

I created new zip with correct folder name and set it directly in the code, next faced another issue: Civicrm checks for presence of extension with same name before updating payment processor (if I am not wrong) and raises error if exists. And it exists for sure because we are doing not install but upgrade.

After about 3 hours it was updated - actually no sense for such tortures, it's enough to override files and update version in database manually.