My custom searches fail

[robinhood]

I have a few custom searches that were written for 4.2, but now do not work in 4.3a1.  Are there instructions somewhere on what has to be updated for 4.3?

Sorry but we are not able to provide this at the moment.
Could not get details for custom search.

Return to home page.

[Donald Lobo]

nothing should have changed with custom searches (in theory at lease)

are these custom searches installed as an extension?

lobo

[robinhood]

One is an extension, but two are not.  Should that matter?

[Donald Lobo]

no, but was curious to see if there was a pattern

pretty sure we did not change any of the in built custom searches or the protocol. Wanna get on IRC and we can help debug

lobo

[robinhood]

Sorry it took so long to report back, but I did resolve the issue.  In 4.3 there was a change in the interface at CRM_Contact_Form_Search_Interface::all() with an extra parameter added.

It was:

Code: [Select]

function all($offset = 0, $rowcount = 0, $sort = NULL, $includeContactIDs = FALSE);but now it is:

Code: [Select]

function all($offset = 0, $rowcount = 0, $sort = NULL, $includeContactIDs = FALSE, $justIDs = FALSE);
An easy fix.

[petednz]

we hit a broken Custom Search yesterday too - will see if i can dig out what eileen's fix was - think it was for http://issues.civicrm.org/jira/browse/CRM-10518

[Eileen]

I fixed it as robinhood described on the custom search we had installed.