Can send SMS by bulk action (off of a search) but not Bulk SMS

[Tiffani Chin]

So... when I choose a group of recipients, I can choose "Send SMS" from the action menu and easily send an SMS to each of them.

However, when I choose the same group and try to send a bulk SMS, some people get SMS, some get many of the same SMS, and some get nothing.

Anyone else figured this one out?

Thanks!
-tiffani

[invisible ink]

I am having this same problem....did you find a resolution?

[Tiffani Chin]

I haven't.  I just upgraded to 4.3 and I was hoping that that would solve the problem -- but it looks like you're already upgraded.

Sorry not to have more info.

[Flying]

I met the same problem ( I think)...

It seems as bulk-sms is only sending to those contacts that have an active e-Mail adress.

I suspect a legacy problem of code from bulk e-Mail onto bulk-sms.

[Donald Lobo]

hey maf:

i suspect the legacy issue of using the same code and queries as civimail (they share a lot of the same codebase)

any chance u can get the civi-coop folks to take a look, debug and file a PR against this.Would be good to get it sorted out

thanx

lobo

[Flying]

Thanks lobo!

I have already put Jaap on the issue!
Good to hear that you share the same suspicion.

[jaapjansma]

I am looking into the issue and if see a solution I can see if I can make a PR. Will keep you posted about it

[jaapjansma]

At a first look all the bulk mailing code looks fine. So it needs some further investigation. has someone an idea where exactly the code might break?

[Flying]

Hi Jaap!

A long-shot, but could this access control issue be somewhat related:

http://forum.civicrm.org/index.php/topic,29031.0.html

This is at least something that shows that the code is still interdependent on bulk-mail.

[jaapjansma]

we have discovered that it is a token related issue. We haven't figured out what exactly the problem is. But we know which token is causing the problems.

[jaapjansma]

An update it was not in the token. There was an error in sms delivery which is the same functionality as mail delivery and which inserted a condition for token values if a contact has an e-mail. The problem is related to https://issues.civicrm.org/jira/browse/CRM-3798 but that issue solved another problem....

[jaapjansma]

The solution is to change CRM_Mailing_BAO_Job at line 585:

from

Code: [Select]

public function deliverGroup(&$fields, &$mailing, &$mailer, &$job_date, &$attachments) {
    static $smtpConnectionErrors = 0;

    if (!is_object($mailer) || empty($fields)) {
      CRM_Core_Error::fatal();
    }

    // get the return properties
    $returnProperties = $mailing->getReturnProperties();
    $params           = $targetParams = $deliveredParams = array();
    $count            = 0;

    foreach ($fields as $key => $field) {
      $params[] = $field['contact_id'];
    }
    $details = CRM_Utils_Token::getTokenDetails(
      $params,
      $returnProperties,
      TRUE, TRUE, NULL,
      $mailing->getFlattenedTokens(),
      get_class($this),
      $this->id
    );
To

Code: [Select]

public function deliverGroup(&$fields, &$mailing, &$mailer, &$job_date, &$attachments) {
    static $smtpConnectionErrors = 0;

    if (!is_object($mailer) || empty($fields)) {
      CRM_Core_Error::fatal();
    }

    // get the return properties
    $returnProperties = $mailing->getReturnProperties();
    $params           = $targetParams = $deliveredParams = array();
    $count            = 0;
    $skipOnHold = true; //do include a statement to check wether e-mail address is on hold
    if ($mailing->sms_provider_id) {
      $skipOnHold = false;
    }

    foreach ($fields as $key => $field) {
      $params[] = $field['contact_id'];
    }
    $details = CRM_Utils_Token::getTokenDetails(
      $params,
      $returnProperties,
      $skipOnHold, TRUE, NULL,
      $mailing->getFlattenedTokens(),
      get_class($this),
      $this->id
    );

[jaapjansma]

I have also filed an issue under: https://issues.civicrm.org/jira/browse/CRM-15702

[Flying]

I sent around 2000 sms using the bulk sms yesterday.
So it is working!

However, 4 people didn’t receive a sms, and what is common for all of them, is that they have ticked off for no bulk e-mail. This is not what I expected, so if there is some code checking for that as well, (at the place you fixed yesterday) this would be relevant to fix as well.

[jaapjansma]

About the no bulk mail option. That one indeed affects the sending of SMS. But I am not sure whether it is a bug or a required functionality. In case of the MAF we can decide whether it is a bug or not... However in more general what do others think about this issue. Is it required to prevent sendnig SMS if a contact has opt out for bulk mailings? In other words could the bulk sms be considered as a bulk mailing?