max instances in civicase config ignored?

[demeritcowboy]

I think there's a name/label mismatch. It works if your name and label happen to be the same, but if not then max instances gets ignored when attempting to create a new activity and there's already the max number of that activity type on the case.

I can confirm it happens on both a 3.3 install and a 4.2 install. Can't check demo because the sample config doesn't have any max_instances beside open case.

In CRM_Activity_Form_Activity::preprocess() it properly gets the name and puts it in _activityTypeName, but then lower down it overwrites that by calling CRM_Core_BAO_OptionValue::getActivityTypeDetails() which returns the label. Seems like just changing that would fix this but might break other stuff. Could set another variable and then use that for the actual check against max_instances in CRM_Case_Form_Activity, but first wondering if I'm the only one seeing this problem?