Price Set Detail report crashes if an item is disabled

[rjlang]

CiviCRM 4.3.5 + Drupal 7.22
If one attempts to run a Price Set Detail custom search report on a price set (e.g., for an Event) in which one or more of the price set items have been disabled, CiviCRM throws an unspecified db error.

Now, a simple fix is to turn the item in the price set back on before you run the report, but for our use case, we periodically run reports while registration is open even if we've turned off items that are no longer available to new registrants. So we'd like to see *all* data, even though some items are disabled, without having to enable those items where they might be chosen by people who are registering while the item is enabled.

The attached patch fixes this issue. It modifies the Price Set Detail report to always return data for all items in the price set, whether or not they are currently enabled. To do this required adding a new argument to CRM_Price_BAO_Set::getSetDetail(), with a default value that preserves behavior for all existing calls to the function.

I'll post this patch here for anyone with a similar use case, and if the admins agree that the change should be rolled into CiviCRM, say so and I'll post an issue in JIRA.

Robert

[zkrebs]

Have you rolled this for CiviCRM 4.5.x? I tried reworking the patch to modify the new file names, and it applied successfully, but then when I ran the report the results were blank. I rolled the patch back.

[rjlang]

Yes. There were some changes needed in CiviCRM 4.4.5; updated patch attached. We've been reapplying it successfully up to the current CiviCRM 4.5.2.

[Michael McAndrew]

if the admins agree that the change should be rolled into CiviCRM, say so and I'll post an issue in JIRA.

Probably a better to do go about this is / to get "the admins" attention is to create the issue, and let them know that you are happy to do the work to get it in core, and then see what they say.