Upgrade 4.3.5 to 4.3.6 fails on error update financial_trxn table

[MarcL]

I just tried this upgrade on a clone of my production site  and it failed at the upgrade database step. It gives an error about update financial_account_id

the full error is as follows

[Error: Update financial_account_id in financial_trxn table]
Exception: "A fatal error was triggered: One of parameters (value: ) is not of the type Integer"

#0 /home/sites/leden/sites/all/modules/civicrm/CRM/Utils/Type.php(326): CRM_Core_Error::fatal("One of parameters  (value: ) is not of the type Integer")
#1 /home/sites/leden/sites/all/modules/civicrm/CRM/Core/DAO.php(977): CRM_Utils_Type::validate(FALSE, "Integer")
#2 /home/sites/leden/sites/all/modules/civicrm/CRM/Core/DAO.php(903): CRM_Core_DAO::composeQuery("SELECT cc.id contribution_id, cc.contribution_recur_id, cft.payment_processor...", (Array:1), TRUE)
#3 /home/sites/leden/sites/all/modules/civicrm/CRM/Upgrade/Incremental/php/FourThree.php(915): CRM_Core_DAO::executeQuery("SELECT cc.id contribution_id, cc.contribution_recur_id, cft.payment_processor...", (Array:1))
#4 [internal function](): CRM_Upgrade_Incremental_php_FourThree::updateFinancialTrxnData(Object(CRM_Queue_TaskContext), "4.3.6")
#5 /home/sites/leden/sites/all/modules/civicrm/CRM/Queue/Task.php(79): call_user_func_array((Array:2), (Array:2))
#6 /home/sites/leden/sites/all/modules/civicrm/CRM/Queue/Runner.php(186): CRM_Queue_Task->run(Object(CRM_Queue_TaskContext))
#7 /home/sites/leden/sites/all/modules/civicrm/CRM/Queue/Page/AJAX.php(44): CRM_Queue_Runner->runNext(TRUE)
#8 /home/sites/leden/sites/all/modules/civicrm/CRM/Queue/ErrorPolicy.php(80): {closure}()
#9 /home/sites/leden/sites/all/modules/civicrm/CRM/Queue/Page/AJAX.php(47): CRM_Queue_ErrorPolicy->call(Object(Closure))
#10 [internal function](): CRM_Queue_Page_AJAX::runNext((Array:5))
#11 /home/sites/leden/sites/all/modules/civicrm/CRM/Core/Invoke.php(258): call_user_func((Array:2), (Array:5))
#12 /home/sites/leden/sites/all/modules/civicrm/CRM/Core/Invoke.php(70): CRM_Core_Invoke::runItem((Array:13))
#13 /home/sites/leden/sites/all/modules/civicrm/CRM/Core/Invoke.php(52): CRM_Core_Invoke::_invoke((Array:5))
#14 /home/sites/leden/sites/all/modules/civicrm/drupal/civicrm.module(436): CRM_Core_Invoke::invoke((Array:5))
#15 [internal function](): civicrm_invoke("upgrade", "queue", "ajax", "runNext")
#16 /home/sites/leden/includes/menu.inc(517): call_user_func_array("civicrm_invoke", (Array:4))
#17 /home/sites/leden/index.php(21): menu_execute_active_handler()
#18 {main}

the same issue happened on upgrading from 4.3.5 to 4.3.6

anyone any suggestions ?

thanks

Marc

[MarcL]

Update still does not work , but I've found a bypass.

The problem is in function update_4_3_6, more specific in the CRM12844 of FourThree.php
if I ignore these

Code: [Select]

$this->addTask(ts('Update financial_account_id in financial_trxn table'), 'updateFinancialTrxnData', $rev);
    $this->addTask(ts('Update Line Item Data'), 'updateLineItemData', $rev);Then the updates passes without any problem.
I even managed that way to the update to  4.4.1 , as I just use the contributions as test, it's not that bad that there can be some errors in it.

I still have no idea what's going wrong, here's what I did to find out :

• installed on a clean database structure of civicrm -> same result
• compared database structure with the clean version -> seems the same
• deleted all contributions, memberships, and all financial data I added  -> same error
• the queries mentioned in CRM-12844 pass without error, most with zero results

Is there anybody who wants to look at my database to find out what's wrong ?

thanks in advance

Marc

[sushant]

We are facing same issue and able to find the reason behind it.
Please check if you have payment Instrument "Credit card" available in CiviCRM (/civicrm/admin/options/payment_instrument?group=payment_instrument&reset=1) If not than you will face this issue while upgrade.

HTh

[chriscant]

Thanks sushant.  Note that the payment instrument is case sensitive and has to be "Credit Card".

[cvining]

Thanks to MarkL especially. Must have taken you some effort to find that.

I've just updated from 4.1.6 all the way to 4.5.3 and this was the last of several bugs I had to get around in the update process. Moral: don't wait so long to upgrade!

Regarding sushant's point, my "Credit Card" entry is not enabled and remains disabled after the upgrade to 4.5.3. For the life of me, I couldn't figure out how to enable it, but then I don't actually use any credit card processing at the moment.

Thanks to all for my shiney updated v.4.5.3!