Tackling the backlog of 'ready to review' extensions

[Dave Greenberg]

The list of extensions that are currently awaiting review / approval follows. Add a reply to this thread indicating that you are grabbing on of them to review. Then post back with your results. Your review should minimally include:

* Checking that there is an adequate description of what the extension does
* Checking for a link to documentation
* Downloading the extension and checking that it installs properly on a compatible CiviCRM version
* Checking if the extension includes any tests (not a requirement but desirable)
* Review the code, checking especially for unescaped parameters to SQL queries. Also check that strings are ts'd.
* Post back your findings here (clearly indicated the extension name).

Extensions Needing Review
* UK Phone Number Validator: https://civicrm.org/extensions/uk-phone-number-validator
* Prevent confirmation from back-office: https://civicrm.org/extensions/suppress-event-confirmation-back-office
* Normalise first name & last name: https://civicrm.org/extensions/normalise-data-entered-firstname-last-name
* No overwrite: https://civicrm.org/extensions/no-overwrite
* Quick contact autocomplete: https://civicrm.org/extensions/quick-contact-autocomplete
* Full Mail Stats: https://civicrm.org/extensions/full-mail-stats
* Optimised autocomplete for contact: https://civicrm.org/extensions/optimised-autocomplete-contact
* Populate Employer for Anonymous User: https://civicrm.org/extensions/popemployer
* Campaign Monitor: https://civicrm.org/extensions/campaign-monitor
* Google Apps sync: https://civicrm.org/extensions/google-apps-sync
* Zaakpay Payment Processor: https://civicrm.org/extensions/zaakpay-indian-payment-processor
* PayLeap Payment Processor: https://civicrm.org/extensions/payleap-payment-processor
* MailChimp Sync: https://civicrm.org/extensions/mailchimp-sync

Extensions In Review
* (Carlos) Duration: https://civicrm.org/extensions/duration
* (Carlos) Summary Fields: https://civicrm.org/extensions/summary-fields
* (Carlos) Option Value Importer: https://civicrm.org/extensions/option-value-importer
* (John) CiviStats: https://civicrm.org/extensions/civistats

[xavier]

Hi,

My request for you, beloved reviewer:  could you do a screenshot of the part that changed (or whatever you think is representing best what the extension brings to the user) and attach it here? We want to add an image to each extension so it's clearer for users what it does

X+

P.S. and any suggestion on how to present an extension better more than welcome

[JohnFF]

Name Normaliser: functions as explained, adjusts text as the text field loses focus, which makes it very convenient to use IMO.

[capo]

I've been taking a look to the Summary Fields extension. Here's what I've found.

Pre-installation review

• Description is brief and adequate. It says exactly what the extension does.
• Didn't find links to the documentation.

Functional review

• Installation worked out properly in a 4.3.7 instance.
• The extension works nice.
• The extension added a tab to the contact record with the summary fields (as in the attached file: summary-fields-datatab.png).
• The extension added a new option in the administration menu: Administer > Customize Data and Screens > Summary Fields (as in the attached file: summary-fields-settings.png).
• After a quick review, calculations seemed to be correct.
• (Possible improvement): Default settings are counting Campaign Contributions, Donations, Event Fees, etc. as membership payments. It can be changed via configuration. But the description -or the documentation- should advice about the existence of a page to configure how the extension works.
• (Possible improvement): At the top of the tab, they are still two buttons that allows the user to edit or delete the summary information. Anyway, as long as it's a Custom Data Group, that can be fixed with some permissions.

Code review

• Code appears to respect CiviCRM standards (2 spaces for indentation, etc).
• They are some comments: useful ones and enough. No more than needed.
• No SQL-injection vulnerabilities were detected.
• (Possible improvement): No tests were found.

[capo]

I'll start now working with Duration, if nobody else is doing it. ;-)

[JohnFF]

Shotgun CiviStats

[capo]

This time, I've been taking a look to the Duration extension. Here's what I've found.

Pre-installation review

• Description is brief and adequate. It says exactly what the extension does.
• Didn't find links to the documentation.

Functional review

• After the installation, as expected, a new field "Duration" is visible (and editable) when recording a contact email (as in the attached file: duration-email.png).
• The field is also visible (and editable) for other activity types, but only mandatory for emails (as in the attached file: duration-otheractivities.png).
• You can select the Duration field when creating an activity report (as in the attached file: duration-reportcreate.png).
• When printing the report, we can see the new column (as in the attached file: duration-reportprint.png).

(I'll continue the review in a second post, as long as I want to send more than 4 files attached).

[capo]

(Second part of the review: Duration)

Code review

• Code is clear and direct. It does what it's supposed to do. No more than that.
• Every function has been commented at the beggining.
• The SQL sentence used to update the duration, is vulnerable to SQL injection (as in the attached file: duration-sqlstring.png).
• In adition, this sentence updates the lastest activity with the same subject that the edited one. That can generate problems too.

[capo]

I'm starting now with Options Value Importer.

[JohnFF]

CiviStats doesn't appear in my list of Extensions.

I didn't feel it was clear on how to activate it, or see the results. Could an example templates file be included?

Other than the api directory there was no templates or CRM directory. Aren't these needed?

[capo]

Here are my comments about Options Value Importer.

Pre-installation review

• The description is adequate and clear. It says what the extension does.
• The extension is in GitHub. Nice! 
• There is a complete documentation in GitHub's README file, on how to install it and use it.

Functional review

• After installation, if you go to Administer > Customize Data and Screens > Custom Fields, then list the fields in one of your Sets of Custom Fields and then click on Edit Multiple Choice Options, you'll see two new buttons: Import Options and Delete Options (as in the attached file: optionsimporter-buttons.png)
• If you choose to Import Options, you'll be asked to select a file. You can specify the separator, the text delimiter, etc (as in the attached file: optionsimporter-uploadfile.png).
• If you choose to Delete Options, it will delete all the options in your custom field.
• (Possible improvement) Currently, it only deletes the first 100 options. If you have more options in a field, you have to run it several times.
• (Possible improvement) If you follow a different route to arrive to the edition of the values of your custom field, buttons doesn't appear. For instance, if you go to Administer > System Settings > Option Groups and you click Options to see the options of the same file you were modifying before, buttons are not visible.
• (Possible improvement) After Deletion, it would be nice to have a link back to the Option Values.

Code review

• Code is clear and direct, and it appears to respect CiviCRM standards (2 spaces for indentation, etc).
• No obvious vulnerabilities were found.
• Almost all the strings are ts'ed (I only found one "VALUE" and one "LABEL" that weren't).
• It says that the maximum size I can upload is 8M, even when my site allows me to upload files up to 128M (I've set that value for upload_max_filesize and post_max_size).

[JohnFF]

Checking out Optimised autocomplete for contact.

[NASACT]

Working on quick lookup. Got screen shots and notes. just need to look at security side.  Will report tomorrow.

[Dave Greenberg]

AJ - Do you mean "Quick contact autocomplete" ?

[mathieu]

I updated the "region lookup" extension page, if anybody would like to review:
https://civicrm.org/extensions/civicrm-region-lookup

I've shown it to a few people, but I have to admit that without an admin form to enter the data (ex: postcode A1A 2A2 => custom field value 1), it's a bit hard to start with (you can use phpmyadmin to import data).

Any feedback on the description / screenshot / documentation?