Include / Exclude custom Search does not work properly

[Fabian_SYSTOPIA]

Dear all,

the Include / Exclude custom Search does not work properly when you include a Smart Group that has "OR" as a Search Operator.

I could reproduce the error on the demo installation:

• go to advanced search, choose "OR" as search operator
• in "Complete OR Partial Name" enter "a", under "Contribution|Contribution Date" select "this year"
• click search and create a smart group from the search results
• go to "custom Searches|Include / Exclude Search"
• include the dynamic group you just created, hit search

Result: The result will use the search criteria from the smart group but ignores the "OR" operator and uses the "AND" operator instead. This means, You will only get contact that fullfill all the search criteria - in our case all contacts that have "a" in their name and donated this year.

Since this is a Custom Search, I am not sure, how to proceed. Should I post a bug report? Should I contact the contributor of the custom search (i think it's Erik Hommel)? Please let me know, if you need more information

Looking forward to hear from you soon
Fabian

[Donald Lobo]

what happens when you just list the contacts (from the manage group screen?) of the smart search? or include the group in advanced search?

does it work right there?

lobo

[Fabian_SYSTOPIA]

Hi Lobo,

thanks for the fast reply.
Yes, from the manage group screen everything works fine.

Regards
Fabian

[Donald Lobo]

ok, so this seems like a include/exclude group issue. If i had to guess, that custom search was written before the 'OR' operator was introduced in civi search.

I think that search should be modified to use the smart group cache and hence be a lot more efficient rather than redoing the query every time (there will be sporadic cache stale-ness, but fairly minor IMO)

wanna take a crack at it? we can help out on irc, might not be too hard

lobo

[Fabian_SYSTOPIA]

Hi Lobo,

I would love to help but I have no developing skills whatsoever and would not even know where to start 

Please let me know if I can help in any other way.

Greetings from Bonn
Fabian

[Donald Lobo]

any chance bjorn or someone else from systopia can take a look at this?

lobo

[Fabian_SYSTOPIA]

Björn wont be able to do it in the near future - we have a huge project with an upcoming system switch that will need all his attention in the next two or three weeks. He may have a look at it afterwards if nobody else can have a look at it meanwhile...

By the way - should I post a bug report?

[Donald Lobo]

yes, do post a bug report

lobo

[Fabian_SYSTOPIA]

Bug Report:
http://issues.civicrm.org/jira/browse/CRM-13606