CRM-12273 contribution upgrade error only partly backported to 4.2?

[davej]

Hi LTS people,

I ran into an error with contributions & price sets when upgrading a 4.1.6 site to 4.2.14 . It looks as though the fix for CRM-12273 "Convert Contribution error when upgrade from 4.1 to 4.2/4.3" was only partially backported to 4.2. See:
http://forum.civicrm.org/index.php/topic,30834.msg132334.html#msg132334
"Fatal error on Upgrade DB to 4.2.alpha1: Contributions - price_set_id NULL"

Is my fix in that topic correct for 4.2? It worked anyway and allowed the upgrade to complete.

Cheers,

Dave

[Eileen]

Dave - although I don't have my head into it enough to really know it seems to make sense as a patch & it looks like it's worth backporting. If you want to do a PR for it I'm happy to pull it in