When editing a contribution: error about fee + net not equal total

[jamie]

The full error is:

The sum of fee amount and net amount must be equal to total amount

It seems to be caused by net_amount and fee_amount being set to '0.00' instead of NULL.

The check is only supposed to be made if either net_amount or fee_amount is set:

Code: [Select]

if (CRM_Utils_Array::value('total_amount', $fields) && (CRM_Utils_Array::value('net_amount', $fields) || CRM_Utils_Array::value('fee_amount', $fields))) {
 ...
If I update the database, changing net_amount and fee_amount to NULL, it works. Similarly, if I change the code to be:

Code: [Select]

$fee_amount = CRM_Utils_Array::value('fee_amount', $fields);
$net_amount = CRM_Utils_Array::value('net_amount', $fields);
if (CRM_Utils_Array::value('total_amount', $fields)) {
      if(($fee_amount && $fee_amount != '0.00') || ($net_amount && $net_amount != '0.00')) {
It also works.

Is the data bad? Or should the code be changed?

[jamie]

There's a JIRA issue here: https://issues.civicrm.org/jira/browse/CRM-14881 which should get included soon.

I went with fixing the code rather than the (existing) data.