Issue with line item data on upgrade from 4.3.5 to 4.3.8

[SarahG (FountainTribe)]

When I attempt to upgrade a site running Drupal6 + CiviCRM version 4.3.5 to 4.3.8 the following SQL statement fails:

Code: [Select]

UPDATE civicrm_line_item cli LEFT JOIN civicrm_financial_item cfi ON cli.id = cfi.entity_id SET cli.label = 'Contribution Amount', cli.price_field_id = 14, cli.price_field_value_id = 17, cfi.financial_account_id = 180, cfi.description = 'Contribution Amount', cli.financial_type_id = 180 WHERE cfi.entity_table = 'civicrm_line_item' AND cli.entity_table = 'civicrm_contribution' AND cli.id IN (3546,3675,3763,3911);
The error message is:
#1062 - Duplicate entry 'civicrm_contribution-4166-17-14' for key 'UI_line_item_value'

I have done some investigation on the line_item table, and noticed that those 4 line items are associated with a priceset field that is associated with an auto-renew membership.  Not sure if this is related to the issue or not.

The full stack trace is:

Code: [Select]

0 CRM_Core_Error::exceptionHandler(Object(DB_Error)) unknown:unknown
1 call_user_func(Array, Object(DB_Error)) /home/beacon/public_html/sites/all/modules/civicrm/packages/PEAR.php:931
2 PEAR_Error->PEAR_Error('DB Error: alread…', -5, 16, Array, 'UPDATE civicrm_l…') /home/beacon/public_html/sites/all/modules/civicrm/packages/DB.php:969
3 DB_Error->DB_Error(-5, 16, Array, 'UPDATE civicrm_l…') /home/beacon/public_html/sites/all/modules/civicrm/packages/PEAR.php:564
4 PEAR->raiseError(null, -5, null, null, 'UPDATE civicrm_l…', 'DB_Error', true) /home/beacon/public_html/sites/all/modules/civicrm/packages/DB/common.php:1905
5 DB_common->raiseError(-5, null, null, null, '1062 ** Duplicat…') /home/beacon/public_html/sites/all/modules/civicrm/packages/DB/mysql.php:898
6 DB_mysql->mysqlRaiseError() /home/beacon/public_html/sites/all/modules/civicrm/packages/DB/mysql.php:327
7 DB_mysql->simpleQuery('UPDATE civicrm_l…') /home/beacon/public_html/sites/all/modules/civicrm/packages/DB/common.php:1216
8 DB_common->query('UPDATE civicrm_l…') /home/beacon/public_html/sites/all/modules/civicrm/packages/DB/DataObject.php:2421
9 DB_DataObject->_query('UPDATE civicrm_l…') /home/beacon/public_html/sites/all/modules/civicrm/packages/DB/DataObject.php:1613
10 DB_DataObject->query('UPDATE civicrm_l…') /home/beacon/public_html/sites/all/modules/civicrm/CRM/Core/DAO.php:160
11 CRM_Core_DAO->query('UPDATE civicrm_l…', true) /home/beacon/public_html/sites/all/modules/civicrm/CRM/Core/DAO.php:907
12 CRM_Core_DAO::executeQuery('UPDATE civicrm_l…', Array) /home/beacon/public_html/sites/all/modules/civicrm/CRM/Upgrade/Incremental/php/FourThree.php:1068
13 CRM_Upgrade_Incremental_php_FourThree::updateLineItemData(Object(CRM_Queue_TaskContext), '4.3.6') unknown:unknown
14 call_user_func_array(Array, Array) /home/beacon/public_html/sites/all/modules/civicrm/CRM/Queue/Task.php:79
15 CRM_Queue_Task->run(Object(CRM_Queue_TaskContext)) /home/beacon/public_html/sites/all/modules/civicrm/CRM/Queue/Runner.php:186
16 CRM_Queue_Runner->runNext(true) /home/beacon/public_html/sites/all/modules/civicrm/CRM/Queue/Page/AJAX.php:44
17 {closure}() /home/beacon/public_html/sites/all/modules/civicrm/CRM/Queue/ErrorPolicy.php:80
18 CRM_Queue_ErrorPolicy->call(Object(Closure)) /home/beacon/public_html/sites/all/modules/civicrm/CRM/Queue/Page/AJAX.php:47
19 CRM_Queue_Page_AJAX::runNext(Array) unknown:unknown
20 call_user_func(Array, Array) /home/beacon/public_html/sites/all/modules/civicrm/CRM/Core/Invoke.php:289
21 CRM_Core_Invoke::runItem(Array) /home/beacon/public_html/sites/all/modules/civicrm/CRM/Core/Invoke.php:72
22 CRM_Core_Invoke::_invoke(Array) /home/beacon/public_html/sites/all/modules/civicrm/CRM/Core/Invoke.php:52
23 CRM_Core_Invoke::invoke(Array) /home/beacon/public_html/sites/all/modules/civicrm/drupal/civicrm.module:405
24 civicrm_invoke('upgrade', 'queue', 'ajax', 'runNext') unknown:unknown
25 call_user_func_array('civicrm_invoke', Array) /home/beacon/public_html/includes/menu.inc:348
26 menu_execute_active_handler() /home/beacon/public_html/index.php:18
27 {main}

[awasson]

I realize you've probably overcome this problem but if not I thought I'd reply with some info I gleaned from some D6 R&D I've been doing. I've found in the few D6 upgrades going from 3.x to 4.4.x that I've had to make my upgrades in two steps.
1) Upgrade from 3.x to 4.1 at which point you change civicrm.settings.php by amending CIVICRM_UF:

Code: [Select]

define( 'CIVICRM_UF', 'Drupal6');
2) Upgrade from 4.1 to 4.4.x and amending civicrm.settings.php with the addition of:

Code: [Select]

require_once 'CRM/Core/ClassLoader.php';
CRM_Core_ClassLoader::singleton()->register();
If on the other hand you came up with another issue and resolution, please post is so we can add it to the documentation.