About how to add the new API entity: ActivityContact

[capo]

I was just revisiting a post about how to retrieve contacts assigned/targeted/who-created an activity (*), and I realized that the API entity ActivityContact doesn't still exists.

I've just wrote a first draft that seems to work fine. You can see it attached to this post (I changed the extension from .php to .txt so I could attach it).

The question is that I still don't know very well how should a Pull Request be. I mean, to add this ActivityContact.php to the core, we should write before some tests, isn't it?

Are there any other step I should follow, before sending the PR? Like creating an issue, or something like that?

Thanks!

(*) - http://forum.civicrm.org/index.php/topic,31718.msg135996.html#msg135996

[xavier]

Awesome. thx!

Indeed, you need to create an issue (so you can reference it in the PR) and write some tests.

One you have your test environement set up (you need a civi installed from git and kill a goat and offer its heart to the phpunits god, check the details on the wiki, it might have been streamlined recently

You can take this one as an example for simple tests:
tests/phpunit/api/v3/PhoneTest.php
and this one on how to create an activity so you can then test your new entity
ActivityTest.php

[Erik Hommel]

Cool capo! Good luck testing and goat killing :-)

[jaapjansma]

Cool! I have just used the return parameters of the activity api to retrieve the target contact return[activity_target_contact] and return[activity_assignee_contact]. But a seperate api is welcome.

[capo]

Ok, issue created: https://issues.civicrm.org/jira/browse/CRM-14414
I'll write the tests as soon as possible.