White screen in 4.4.3 if I add the array argument to ts for extension domain

[lolas]

If I include any ts call in my extension that uses the array argument I get a white screen with no error in the Apache, Drupal or CiviCRM logs. This is happening in one 4.4.3 install. I haven't yet tested it on others, instead I wanted to ask if there is a minimum version compatibility on this change?

Code: [Select]

  -          array('title' => ts('Contact Name'),
  +          array('title' => ts('Contact Name', array('domain' => 'org.civicrm.cdntaxreceipts')),

(The above causes a white screen on this install)

[mathieu]

It should be working from 4.3.x onwards.

* are you using native gettext, or default phpgettext? (native gettext requires you to define a constant in your civicrm.settings.php)
* to reproduce the issue, do I download the latest version of the extension from git/master, and patch the line of your example? do i need to go to a specific page, or is it happening when the extension is installed?

[lolas]

Mathieu,

This server (client's external cheap hosting) doesn't have gettext support compiled into php. We are using the default php-gettext.

I wouldn't want to ask you to take up your time testing it for me at this point because it is very likely server specific. I just tested it on one of our standard servers on 4.4.4 and it is fine.

The problem site has a multilingual database and the default language is French (Canada).

[lolas]

Thanks for your reply btw.

I forgot to say though that is doesn't really matter which page of our extension. Any use of that form of ts function gives the result on this server.
The example from above is in the report the extension provides at line 19 (https://github.com/jake-mw/CDNTaxReceipts/commit/ef2c95a8e1ab3c1bd06b2bd42f6e6f80478150e6#diff-edac228b91f1873c3b7b24c4af3164bfL19)

To test I checked out the last commit before Karin added the updated ts calls (https://github.com/jake-mw/CDNTaxReceipts/commit/d7363154fb0873ee2fcd3f52fd8a1e70fb9c3520) which works fine on this server. Then I add in any one ts call with the second argument and boom!

If you have any troubleshooting suggestions let me know otherwise I will be filing this issue for a later date (not needed immediately) and creating a patched version of the extension for this customer.

[mathieu]

Thanks for the references, I'll try to test it on another server. It's an issue that could potentially affect a lot of people.

Btw, off-topic, but in SQL queries, while glancing one of the diffs (cdntaxreceipts.db.inc line ~ 101), you should use the following syntax:

Code: [Select]

$sql = "SELECT l.id, l.receipt_no, [...]
     FROM cdntaxreceipts_log l
     INNER JOIN cdntaxreceipts_log_contributions c ON l.id = c.receipt_id
     WHERE is_duplicate = 0 AND l.id = %1";

$params = array(
  1 => array($receipt_id, 'Positive'),
);
$dao = CRM_Core_DAO::executeQuery($sql, $params);
In your case, the $receipt_id is probably not user-submitted and low risk of sql-injection, but you never know how people can call those functions and forget to sanitize input. I find that it also helps to validate bugs, in case $receipt_id == ''.

[mathieu]

@Lola: I should have looked into this earlier, but ends up that extension is probably indeed what was causing a white screen. Probably the host didn't have gettext enabled at all, so it was probably crashing on a "unknown function" PHP error.

I did some testing with extensions for phpgettext and filed a patch & PR for 4.4.6 here:
https://issues.civicrm.org/jira/browse/CRM-14769
https://github.com/civicrm/civicrm-core/pull/3395

If you could test, it would be much appreciated. I also found a weird bug that was affecting native gettext in some circumstances.

[lolas]

Hello Matthieu,

Thanks! 
I am going to test it now. I'll see how it goes and comment on the github pull request as well as here.

[lolas]

Excellent it fixes the problem reported. Thanks a lot!
I've commented on the JIRA issue and pull request. I hope this gets merged soon.