[FIXED] Batch update via Profile - copy icon fails for fields of 'select' type

[ken]

This behaviour works on the 4.4 Demo and fails on the 4.5 Sandbox.

• Create custom data for a Contact which contains a field with format 'select'
• Create a profile that displays that field
• On the results of a contact search, select the 'Batch update via Profile' task and the Profile just created
• Fill in the field for the first row and press the Copy Icon, to reproduce that value in subsequent rows

The expected behaviour is the contents of the field in the first row should be copied to all rows. This happens in 4.4 but not 4.5.alpha2.

I've tracked the problem to lines 142-152 of templates/CRM/common/batchCopy.tpl but I can't resolve it any further because I lack JS skills.

Code: [Select]

        if (elementId.is('select') === true && firstElement.parent().find(':input').select().index() >= 1) {
          // its a multiselect case
          firstElement.parent().find(':input').select().each( function(count) {
            var firstElementValue = cj(this).val();
            var elementId = cj('.crm-copy-fields [name^="field["][name*="[' + fname +'][' + count + '"][type!=hidden]');
            elementId.val(firstElementValue).not(":first").change();
          });
        }
        else {
          elementId.val(firstElementValue).change();
        }

The outside 'if statement' is the issue: in 4.5 the 'if' part is taken, while in 4.4 the 'else' part is taken.

[Yashodha Chaku]

ken:

Can you file an issue for same for 4.5 in our issue tracker.

Thanks!
Yashodha

[Yashodha Chaku]

Filed https://issues.civicrm.org/jira/browse/CRM-14927 for the same.

[Yashodha Chaku]

ken :

We have fixed the same in https://github.com/civicrm/civicrm-core/pull/3592.patch

It will be available in our next release.

Thanks for catching this!
Yashodha

[ken]

Yashodha,

Thanks for fixing this!

Ken

[ken]

This fix works in 4.5.beta1. Yay!