SagePay extension

[Upperholme]

Not sure if this is the best place to post this, but couldn't find anywhere better, so here goes:

I've just installed the SagePay payment processor extension into a D7/Civi 4.4.6 set-up, and immediately got the following:

Strict warning: Declaration of uk_co_circleinteractive_payment_sagepay::singleton() should be compatible with & CRM_Core_Payment::singleton($mode, &$paymentProcessor, &$paymentForm = NULL, $force = false) in CRM_Extension_Manager_Payment::_runPaymentHook() (line 194 of /data/www/html/hcvdrupalv1/sites/all/modules/civicrm/CRM/Extension/Manager/Payment.php).

Thought the develop might be interested in this. Yet to test the processor to see if works.

Thanks to Circle for making this processor available.

[andyw]

Hi Upperholme,

I noticed that problem as well when testing on Civi 4.5 the other week - is that php 5.4 you're running it on by any chance?

Just trying to work out if it's been like that for ages, and is now being shown because of stricter php warnings - or the calling spec of CRM_Core_Payment::singleton() has been updated recently.

Either way, I'll sort it out, get rid of the warning then let you know when that's done.

Hope that's ok,

Andy

[Upperholme]

Thanks Andy

Very helpful. PHP version 5.5.13. This is the first time I've installed this extension, so can't offer anything more at this point.

[andyw]

Great, thanks for the info. It's probably stricter warnings in later php versions that is causing that then I think.

It should still work ok, but I'll get that fixed all the same.

Many thanks,

Andy

[Upperholme]

That's good news. As we test, I'll let you know of anything untoward happening.

Thanks again.

[andyw]

Hi there,

That should be fixed, have uploaded a new version to the extensions directory, 2.6. Was just a case of the newer versions of php being a bit more strict about their warnings.

If you're just testing it at the moment, probably best to uninstall it first, then install the updated version - have unfortunately never managed to get the upgrade thing to work.

Hope that's ok,

Andy

[Upperholme]

Thanks Andy, that's really helpful.

[Upperholme]

Hi Andy
Finally getting ready to go live with the project that uses your extension.
We have version 2.6 of the extension installed on Civi 4.4.6 and the current stable Drupal 7.
PHP version is 5.5.14.
Getting the following warning when testing the processor:

Code: [Select]

Strict warning: Only variables should be passed by reference in uk_co_circleinteractive_payment_sagepay->doTransferCheckout() (line 274 of /data/www/html/drupalv1/sites/default/extensions/uk.co.circleinteractive.payment.sagepay/sagepay.php).
 I assume this is similar to the one we spotted a while back, and not critical.

Thanks
Graham

[andyw]

Hi Graham,

Yes, it's another warning, not anything critical - I have tried to track it down, but I'm not able to reproduce that one unfortunately. Nor can I see anything on that line that should really cause that - there's nothing being passed by reference on line 274.

Admittedly, I've only got access to a machine running php 5.4, but they should be the same in their handling of E_STRICT warnings as far as I'm aware.

So I'm not sure, if the warning is appearing to end-users, it could probably be suppressed by some configuration changes to your php.ini or .htaccess file - some details on that here:

http://serverfault.com/questions/375992/hide-strict-errors-on-php-5-4

But yes, it's not anything that should interfere with the extension working - it's just a bit annoying.

Andy

[Upperholme]

Hi Andy

Many thanks for looking into this.

Everything does seem to be working fine at this end, so we're not particularly concerned, and will ensure that the warning is hidden from end users.

[andyw]

Great, if I ever do work out where that one is coming from, I will get it fixed - but it's a bit of a mystery that one at the moment.

Cheers,

Andy