Multiple custom records - limit not working [FIXED]

[clarkac]

I set up a custom field set, allowing multiple records and setting a limit of 3 records.  However, this limit is not enforced at all.  This is reproducible on the 4.4 sandbox (see custom group temp for a parent contact, if it's still there).  Any comments before I raise this is an issue?

[Dave Greenberg]

Can you test this in 4.5 to see if it's still not enforced? http://drupal.sandbox.civicrm.org/

[Coleman Watts]

When you say not enforced "at all" do you mean in the UI or the api?

[clarkac]

That was a fast reply!  Yes, 4.5 does restrict the number but gets it wrong.  It allows one more record than is permitted - I stated a max of 3 and it allowed 4.  I tried a max of 2 and it allowed 3.  This is in the UI.

Slightly different point, once you've set this limit there's no way to see what it is.  The custom field set screen should really display this number, shouldn't it?

[Dave Greenberg]

Andy - please file an issue for this against 4.5 (both the limit +1 and not displaying the limit when viewing the data set) - and if possible include a pull request against master to correct both.

[clarkac]

Issue https://issues.civicrm.org/jira/browse/CRM-15026 raised.  I was wrong about the maximum number not displayed, it is displayed just fine on the custom field set screen.

Sorry, I am not competent to do the pull request.  I'm an ex-developer, now an implementer so not familiar with the technology.  Guess I should learn...

[Dave Greenberg]

Ok - issue has been resolved, fix is https://github.com/civicrm/civicrm-core/pull/3724

[clarkac]

Thanks - I just installed 4.5 beta 3 and this now works.