Ampersand character still invalid in x_first_name field

[mdlueck]

With CiviCRM 4.4.6 sending a credit card transaction to Authorize.net with an ampersand character in the x_first_name field field causes the transaction to fail within CiviCRM.

Code: [Select]

#CiviCRM.log
   [x_first_name] => Capt. Mike & Mrs.
Aug 26 11:18:58  [info] E00003: An error occurred while parsing EntityName. Line 32, position 30.contact id=26127 (deleting contribution 97839
Aug 26 11:18:58  [info] E00003: An error occurred while parsing EntityName. Line 32, position 30.contact id=26127 (deleting recurring contribution 32

Upon discovering this page:
"[CRM-10733] Authorize.net Recurring transaction XML doesn't escape ampersands"
https://issues.civicrm.org/jira/browse/CRM-10733

I suggested to the client they not send through the ampersand character. Indeed, that resolved the issue.

I already updated the comments in CRM-10733 with this information. What else needs to be done in order to reopen this issue?

I am thankful,

[Michael McAndrew]

What else needs to be done in order to reopen this issue?

Have had a quick read through 10733,  I reckon that because this is fairly edge case (people shouldn't really have & in their first names) the way to 'reopen this issue', would be to actually do the work on coming up with a workable solution and implementing it, or pay some to do so.  I think it is not likely to get fixed without that.

[mdlueck]

Have had a quick read through 10733

So the bug got closed without actually fixing the problem? I quote from the report:

Resolution: Fixed/Completed

What about "Deepak Srivastava added a comment - 31/Aug/12 12:02 PM"... looks like fixes were committed.

Why would I think anything other than the problem was history back in version  4.2.1?

I am thankful,

[Michael McAndrew]

So the bug got closed without actually fixing the problem? I quote from the report:

See below from the issue comments - the fix takes care of most of the problems.  I'm not familiar with the edge cases that it does not fix, but if you want to fix them it is likely going to involve some effort on your part.

- Per illegal xml chars in http://www.w3.org/TR/xml/#charsets, the fix takes care of most of the problems.

- Also checked dash is xml safe, and double dash works fine.

- Also made the fix to bounce and display error. So even if some very special input fails, user will be notified with the error.

- Please note a strict encode / escape submits input to Auth which is not very readable and therefore been avoided.

[mdlueck]

Upon yet further review of the OP:

In my case, I happened to use an ampersand in the name of the contribution page, which resulted in all recurring transactions failing silently.

Aaahhh, so this bug was not focusing on CC data fields, but rather the internal name of the contribution page.

Shall I open a new/separate bug report since it was in this case CC data fields and not something internal to CiviCRM?

I am thankful,

[Michael McAndrew]

Never a bad idea to open a new well written bug report about an identfiied issue, IMO.

Does not guaruntee a fix, but good to have it out there.