Drupal/4.5 - function canProfilesDedupe

[rocxa]

The function:

canProfilesDedupe in CRM/Event/Form/ManageEvent/Registration.php line 729

requires that any fields in the dedupe rule are also *required fields in the selected profiles on the event/contribution form.

Line 791:: $combos[$icombo][$ifield] = ($combos[$icombo][$ifield] != 2 && !$field['is_required']) ? 1 : 2;

Is there a reason why the fields need to be *required rather than just on the form?

I can see why they need to be on the selected profile forms so that the dedupe rule has a chance of being useful, but making the profile fields required means that you have to either; force people to fill out data they may not have (losing donations/registrations) or lose the dedupe facility on those that do actually fill out the fields.

My thoughts are that the required aspect of the canProfilesDedupe chgeck should be removed or optional?