api breaking changes 4.5

[Eileen]

I just regenerated the test examples & you can see the changes here

https://github.com/civicrm/civicrm-core/pull/4256

Of note to extension writers there are breaking changes around the soft_credit & honor_contact fields (both breaking of the test contract & non-contract changes) and there are also breaking changes around whether pseudoconstants are returned as values or labels.

To put it simply - beware. The breakages around honor_contact are somewhat predictable but the ones around the psuedoconstants are not.

A key function of the api is to make it possible for extension writers to be more version agnostic with their extensions - rather than having to write a release of the extension per api version. However, this doesn't always happen.

[totten]

Is this something that someone is likely to fix -- or should it just get noted on http://wiki.civicrm.org/confluence/display/CRMDOC/API+changes ?

[Eileen]

It should be fixed - because the point of writing tests is that you write the tests in exchange for the tests being respected. I'm feeling a depressed after discovering this so will think more about it later in the week

[Eileen]

update - Dave fixed the test-breaking changes - create has been fixed so it still supports honor_contact_id & soft_credit_to