Recurring contribution receipt - update links should be public and encrypted

[ken]

I have a patch for this issue, so I'm seeking agreement to raise an issue and supply a PR.

When a donor makes a recurring contribution, and the payment processor supports this, the receipt includes 3 links.

• Cancel
• Update
• Update billing

It seems reasonable to expect these links should be Public (not all donors are logged in) and Encrypted (this information is private).

However, in /CRM/Contribute/xml/Menu/Contribute.xml these URLS are neither public nor encrypted.

Here's my patch against 4.5.0 for 2 out of 3 of these links (I don't use the third, but it would be symmetric with these changes).

Code: [Select]

--- ./CRM/Contribute/xml/Menu/Contribute.xml 2014-09-18 21:44:43.000000000 +1000
+++ /var/www/citybibleforum/sites/all/modules/civicrm/CRM/Contribute/xml/Menu/Contribute.xml 2014-09-21 00:06:17.820216388 +1000
@@ -229,6 +229,8 @@
     <title>Cancel Subscription</title>
     <page_callback>CRM_Contribute_Form_CancelSubscription</page_callback>
     <access_arguments>make online contributions</access_arguments>
+    <is_ssl>true</is_ssl>
+    <is_public>true</is_public>
   </item>
   <item>
     <path>civicrm/contribute/onbehalf</path>
@@ -246,6 +248,8 @@
     <title>Update Subscription</title>
     <page_callback>CRM_Contribute_Form_UpdateSubscription</page_callback>
     <access_arguments>make online contributions</access_arguments>
+    <is_ssl>true</is_ssl>
+    <is_public>true</is_public>
   </item>
   <item>
     <path>civicrm/contribute/subscriptionstatus</path>


[ken]

See my commit for this change at https://github.com/kenwest/civicrm-core/commit/019af4edcb45a58f8b729aa0349761750a6765f8