[WP] Civi 4.5.1 - Multiples issues with "Add event registration"

[Coleman Watts]

Could you please edit that file (templates/CRM/common/TabHeader.js) and add

Code: [Select]

CRM.console('log', 'tab: ', tab);to the top of the function (as the first line, just above "var oldClass = ...") and then run the page again - report back here what your browser console says.

[SemperFi]

I've 2 new errors (without impact on how things are displayed) :

ReferenceError: tab is not defined
CRM.console('log', 'tab: ', tab);
TabHeader.js, line :100

TypeError: CRM.tabHeader.updateCount is not a function
CRM.tabHeader.updateCount(ui.tab, data.tabCount);
TabHeader.js, line :42

[Coleman Watts]

At this point a console backtrace would be most helpful. If you enable your "script" tab, then go back to the console, run the page again, and the error message should contain an "expand" button to show the full backtrace.

[SemperFi]

Is that what you were expecting Coleman ?

ReferenceError: tab is not defined
TabHeader.js, Line 94

Code: [Select]

/**
   * Update the counter in a tab
   * @param tab jQuery selector
   * @param count number
   */
 
  [color=orange][b]CRM.console('log', 'tab: ', tab);[/b][/color]
 
  CRM.tabHeader.updateCount = function(tab, count) {
    var oldClass = $(tab).attr('class').match(/(crm-count-\d+)/);
    if (oldClass) {
      $(tab).removeClass(oldClass[0]);
    }
    $(tab)
      .addClass('crm-count-' + count)
      .find('a em').html('' + count);
  };
Line 110


TypeError: CRM.tabHeader.updateCount is not a function
TabHeader.js, Line 37

Code: [Select]

        ui.panel
          .off('.tabInfo')
          .on('crmLoad.tabInfo crmFormSuccess.tabInfo', function(e, data) {
            if (data) {
              if (typeof(data.tabCount) !== 'undefined') {
                [color=orange][b]CRM.tabHeader.updateCount(ui.tab, data.tabCount);[/b][/color]
              }
              if (typeof(data.tabValid) !== 'undefined') {
                var method = data.tabValid ? 'removeClass' : 'addClass';
                ui.tab[method]('disabled');
              }
            }
          });
Line 49

TypeError: CRM.tabHeader.updateCount is not a function
Summary.js Line 96

Code: [Select]

      // Update changelog tab and contact footer
      if (response.changeLog && response.changeLog.count) {
        [b][color=orange]CRM.tabHeader.updateCount('#tab_log', response.changeLog.count);[/color][/b]
      }
Line 49

[Coleman Watts]

I think I figured out the issue:
https://issues.civicrm.org/jira/browse/CRM-15456

[SemperFi]

Exact we don't use Membership and Contribution
I added an other error due to the same issue in Summary.js Line 96, see my previous post.
I'll test the proposed fixes and let you know
Thanks Coleman

[SemperFi]

When I apply the fix it says :

SyntaxError: missing ; before statement

(last line of TabHeader.js)

Code: [Select]

CRM.tabHeader.resetTab = function(tab) {
    var $panel = CRM.tabHeader.getTabPanel(tab);
    if ($(tab).hasClass('ui-tabs-active')) {
      $panel.crmSnippet('refresh');
    }
    else if ($panel.data("civiCrmSnippet")) {
$panel.crmSnippet('destroy');
    }
   };
 })(CRM.$);

[Coleman Watts]

Is it possible the patch did not apply cleanly? My IDE and browser are not seeing any syntax errors, and I just linted with jshint.com and couldn't find any errors there either.

[SemperFi]

You're right, all issue fixed now ! Thanks Coleman

[SemperFi]

I think there's a better fix than this, but here's a very quick patch to get you back on your feet:

Code: [Select]

diff --git a/templates/CRM/Event/Form/Participant.tpl b/templates/CRM/Event/Form/Participant.tpl
index 158cf90..3157783 100644
--- a/templates/CRM/Event/Form/Participant.tpl
+++ b/templates/CRM/Event/Form/Participant.tpl
@@ -341,7 +341,7 @@
         var $form = $('form.{/literal}{$form.formClass}{literal}');
 
         // don't show cart related statuses if it's disabled
-        {/literal}{if !$enableCart}{literal}
+        {/literal}{if !$enableCart && $pendingInCartStatusId}{literal}
           var pendingInCartStatusId = {/literal}{$pendingInCartStatusId}{literal};
           $("#status_id option[value='" + pendingInCartStatusId + "']").remove();
         {/literal}{/if}{literal}

Hello Coleman,
Has it been included in the 4.5.2 release or should I manually change it ?
Thanks

[Coleman Watts]

No I'll try to get it into 4.5.3.

[SemperFi]

Thanks for following the topic Coleman.