Checkbox "counted?" in participant role options not updated in 4.4.9 lts

[erwindeclerck]

Fresh install of LTS 4.4.9
Problem doesn't exist in 4.5.2. anymore.
I have tried to find out where it goes wrong but can't find anything.
Is this something for a patch for the LTS version?

Kind regards,
Erwin

[Eileen]

Can you provide steps to reproduce?

[erwindeclerck]

Okay,
Drupal 7 + Civicrm 4.4.9. fresh install
Logged in as admin:
Go to SITE/civicrm/admin/options/participant_role?group=participant_role&reset=1
Edit one of the role options and change the checkbox => Counted? from set to unset  e.g:SITE/civicrm/admin/options/participant_role?group=participant_role&action=update&id=99&reset=1
SAVE => Counted stays unchanged.
If however you create a new participant role, and you don't set te Counte? checkbox, this field is saved as unset.
Once you set it, you can save this new value, but you can not unset it again...
The values of the other fields update like they should.
Kind regards.
Erwin

[erwindeclerck]

Good morning,

After some better investigation and comparing 4.4.9 to 4.5.4 I found an important difference:
- in file: \civicrm\CRM\Admin\Form\Options.php
- in function:  public function postProcess() on line 360
-> around lines 398 of 4.4.9

Version 4.4.9:

      // set db value of filter in params if filter is non editable
      if ($this->_id && !array_key_exists('filter', $params) && !$this->_gName == 'participant_role') {
        $params['filter'] = CRM_Core_DAO::getFieldValue('CRM_Core_DAO_OptionValue', $this->_id, 'filter', 'id');
      }

changed to in 4.5.4:
 
      // set value of filter if not present in params
      if ($this->_id && !array_key_exists('filter', $params)) {
        if ($this->_gName == 'participant_role') {
          $params['filter'] = 0;
        } else {
          $params['filter'] = CRM_Core_DAO::getFieldValue('CRM_Core_DAO_OptionValue', $this->_id, 'filter', 'id');
        }
      }

Replacing this if-clause resolves the issue. I don't see any negative side effects...

Kind regards,
Erwin

[Eileen]

Do you want to log a ticket - we can patch 4.4 branch with that

[erwindeclerck]

Thanks Eileen,
I posted a reply on the ticket I opened yesterday  (lobo)
https://issues.civicrm.org/jira/browse/CRM-15620
I hope it's the right way to do it;
Kind regards
Erwin