'Send email to contacts' broken if contact has multiple Primary emails

[ken]

When sending emails to contacts I get unexpected "Email will NOT be sent to N contacts" messages, even though the contacts all have valid email addresses, are not deceased and are not on-hold.

While digging I found one of my contacts had TWO primary email addresses.

What happens is ...

• CRM_Contact_Form_Task_EmailCommon::buildQuickForm() calls CRM_Utils_Token::getTokenDetails() with the list of contact Ids as returned in the search results
• CRM_Utils_Token::getTokenDetails() calls CRM_Contact_BAO_Query::apiQuery() passing in the number of contacts as the $count
• The query is run with a LIMIT modifier
• But the query joins the contact to the primary email, so if a contact has more than one Primary email, the LIMIT stops another contact's row being returned.

As this is Core code I'm not sure how to fix it. Could someone comment?

I don't know why a contact would have more than one Primary email, but I do remember merging contact records for the example I have.

[petednz]

That would be bad news if merging creates multiple primary emails - can you test and confirm/deny?

[jaapjansma]

What version are you on? I remember doing a merge of contacts in civi (4.5 version) and remember sending an e-mail to the wrong e-mail address. I thought I had done the merge wrong but it might be core code.... So I set the right e-mail address to primary by hand.

[ken]

I'm on 4.5.3. I've been unable to reproduce the problem (multiple primary emails) by merging contacts.

[jaapjansma]

I tried to duplicate the issue on a civi 4.5.4 install and it looks everything works fine. I merged a contact and I got only one primary e-mail address

[ken]

On my production machine I merged 2 contact records and the resulting contact had 2 primary emails.

I just tried reproducing that on my test server and couldn't replicate it. This is weird.

[prdsutte]

we had a similar problem with a client just now.
It's indeed an issue with primary emailadresses.
send email to contacts becomes broken.
version: 4.5.6

trying to replicate other cases where it happens.
we had a case recently where merging of adresses was a problem.
trying to collect more data where/when it happens.