If Pay Later during Grace, but reconciled when Expired member dates incorrect

[petednz]

Discussed with Eileen - she has a suggestion she will post here

but the scenario is

Person renews during Grace with a Pay Later - reconciliation (ie Contribution being set to Completed) does not happen immediately - meanwhile Member Status becomes Expired.

When Contribution is set to Completed it therefore calculates the new End Date based on the status being Expired - and hence begins a new membership cycle.

I think that if the 'Payment Received' Date is 'during' the Grace period, then it should be handled as such.

Eileen thinks there is a hook that could be used in an Extension for this but first i want to sound out what the collective view on this should be

It 'feels' to me that the correct behaviour should be 'if payment received is prior to 'end date'' then treat as a 'renewal' not as a 'new membership'

[Dave Greenberg]

If I understand what you're saying, the payment is NOT actually received prior to membership expiration (only a promise to pay). Since there's no 'rule' about how long it's ok to wait for actual payment after the pay later 'promise', I think the current behavior is a reasonable default.

In other words, if that member promises to pay during the Grace period but doesn't actually send in their payment for another 6 months - would you still want to 'count' the fact that the Pay-later renewal was initially received during Grace period??

[petednz]

hi dave - what i was trying to describe is when the payment IS received in the bank during grace - but due to being a small org where bank to accounts system to civi reconciliations only occur occasionally by the time the 'payment completed' is entered in to civi the Expired Date has passed

and even though I then enter the 'date received' as having been during Grace, it still treats it as Expired and starts a new cycle.

Example dates

End Date = March 31
End of Grace = April 30
Payment Received = April 25
Civi reconciliation done = May 5

outcome. new membership cycle with new end date of May 4th rather than March 31

[Dave Greenberg]

If you are recording Payment Received date on the membership renewal form as April 25 (in the case below), then I agree that it should be handled as a renewal, and it sounds like there's a bug (the receive_date form value is not being considered in post processing).

[petednz]

https://issues.civicrm.org/jira/browse/CRM-15735