Problem with Drupal "prefix" based language detection, and "metatag" module

[mathieu]

I found that if the "metatag" module is enabled in Drupal (useful for Facebook "og" metatag when users share pages), on a multilingual site that uses prefix-based language detection (ex: /en/civicrm/contribute[...]), Drupal gets confused with the title of pages (the title shown in the titlebar of the browser, i.e. the <title> element).

The problem is in civicrm/drupal/civicrm.module:

Code: [Select]

/**
 * Implementation of hook civicrm_metatag_page_cache_cid_parts_alter
 * Append the query string to the key under which the page title is cached to prevent cross-contamination
 * from urls such as civicrm/contribute/transact
 *
 * If metadata module is not installed this function will not fire
 * @param array $cid_parts
 */
function civicrm_metatag_page_cache_cid_parts_alter(&$cid_parts) {
  if (substr($cid_parts['path'], 0, 7) == 'civicrm') {
    $cid_parts['path'] .=  '/' . md5(implode('_',$_GET));
  }
}

This assumes that the path does not have a language prefix (en/fr/...).

I worked around it for now by using:

Code: [Select]

function civicrm_metatag_page_cache_cid_parts_alter(&$cid_parts) {
  if (substr($cid_parts['path'], 3, 7) == 'civicrm' || substr($cid_parts['path'], 0, 7) == 'civicrm') {
    $cid_parts['path'] .=  '/' . md5(implode('_',$_GET));
  }
}

However, this assumes that the language prefix is maximum 2 characters. A better solution is probably just to use "strpos()" to check whether "civicrm" is in the path.

Any thoughts?

[Coleman Watts]

That sounds reasonable.

[mathieu]

I'm not sure if that message was SEO spam, but it reminded me to send a pull-request for this issue in 4.6:

https://issues.civicrm.org/jira/browse/CRM-16039
https://github.com/civicrm/civicrm-drupal/pull/248