Contribution Summary Report: Why the "Do not use filter on Date" error?

[JonGold]

If you run the Contribution Summary report, do NOT group by date, and filter by date, you get the error message: "Do not use filter on Date if group by Receive Date is not used".

Can anyone explain to me why this is?  I suspected it's unnecessary, so I commented that error out in Summary.php and everything worked exactly as I expected.  It also seems like it's reasonable to want to ask a question like, "How much money did we bring in last year, grouped by financial type?"  Still, someone obviously thought this was important enough to code a custom formRule.  Ideally we could get rid of this.

[magnolia61]

I absolutely agree with this 'complain'! What changes did you make to which file (summary.php in which path)
Can you submit a PR for inclusion in core civicrm?

[JonGold]

I'm happy to submit a PR - and my work with the Membership Detail report (CRM-19517, CRM-19520, CRM-19521) leads me to believe that this is probably a legacy error which can be safely removed.

For now, if you'd like to make the same change, find this line in CRM/Report/Form/Contribute/Summary.php (it's line 599 in the master branch):
        $errors['receive_date_relative'] = ts("Do not use filter on Date if group by Receive Date is not used ");

You can simply comment it out.