Improvements for civicrm_og_sync admin sync

[indigocivi]

Hi,
this forum looks like the right place for a feature request.

Civicrm_og_sync (for Drupal) is a cool little module.

Unfortunately it lacks the ability to sync og administrators to the according civicrm acl group. It only syncs the group node author and it seems, it never removes them.

My suggestion would be to use an og permission check for the is_admin test.

Something like that in hook_og_membership_insert and hook_og_membership_update:

Code: [Select]

$is_admin = og_user_access_entity('administer group', 'node', $gid, $account);
$gid is of course the og group id.
$account ist the user object created with user_load($og_membership->etid).

So if a Drupal User has the og permission to administer members of his organic group, he would also be able to administer contacts of his group in CiviCRM.

There can be many og admins and they can always change, so just syncing the node author is probably not the best way.

Feedback is welcome.

[petednz]

My vague recollection is that OG synch did put the 'admins' of the OG in to the civi ACL group. I don't have access currently to test this on a site where I expect this to work, but this is what i expect

- you create an OG
- it creates 2 groups in civi, one ACL, one for the OG members
- you add someone to OG, they are added to the Civi og members group
- you add someone as Admin to OG and they get added to the civi ACL group

[indigocivi]

Hi,
CiviCRM groups (2 per og group, one mailinglist and one ACL) are created and og membership is synced, that's right and it's pretty cool.

you add someone as Admin to OG and they get added to the civi ACL group

OG Admins are not synced, only the group node author is added to the ACL group.
If one changes the group node author, this user is also added to the ACL group.

My suggestion is to not rely on the node author but check if a a user has a specific permission in his og group with og_user_access_entity().

I solved that for my use case with a custom Drupal module but I would like to see a better admin-sync handling in CiviCRM.
So I decided to post a feature request here.

[petednz]

well i am not sure when things changed and i won't be able to check on the site we had this running on for a while.

but if changes in OG or in Civi 4.5 (our site will be on 4.4.x LTS) means this has broken then this is probably one of those itches it would be good if you can scratch yourself.

if you are able to spin up a custom module to resolve this, then can you take a look at the og-civi code and have a go at fixing it for 4.5?

[indigocivi]

well i am not sure when things changed and i won't be able to check on the site we had this running on for a while.

I had a look at older civicrm source code on github.
Yes, this module changed significantly, probably because og-7.x-2.x was totally rewritten.
The check for og admin was different before and obviously synced correctly (it was working for you).

So this is not a feature request and actually misplaced in this forum because this functionality was already there in earlier releases, but broke.
I can't believe that there is no issue for that yet in https://issues.civicrm.org/
I'll see what I can do.

[indigocivi]

Here is the new issue:
https://issues.civicrm.org/jira/browse/CRM-15974