CiviMail link tracking is case sensitive - fails on uppercase link tag param (?)

[Chris Burgess]

We have users pasting HTML in which has been composed externally (using various HTML editing tools). This is CiviCRM 2.0.4.

Some of the tag params are uppercase and some lowercase. CiviMail appears sensitive to uppercased parameters on links, so this input:

Code: [Select]

<ul>
<li><a href='http://google.co.nz'>This link works</a></li>
<li><A HREF='http://google.co.nz'>This link won't</A></li>
<li><A HREF='http://yahoo.co.nz'>This link doesn't</A></li>
<li><a href='http://yahoo.co.nz'>This link does</a></li>
</ul>

Results in this output:

Code: [Select]

<ul>
<li><a href='http://www3.greens.org.nz/sites/all/modules/civicrm/extern/url.php?u=4366&qid=170776'>This link works</a></li>
<li><A http://www3.greens.org.nz/sites/all/modules/civicrm/extern/url.php?u=4367&qid=170776>This link won't</A></li>
<li><A http://www3.greens.org.nz/sites/all/modules/civicrm/extern/url.php?u=4367&qid=170776>This link doesn't</A></li>
<li><a href='http://www3.greens.org.nz/sites/all/modules/civicrm/extern/url.php?u=4366&qid=170776'>This link does</a></li>
</ul>

Seems like it just needs a case-insensitive regex in CRM_Mailing_BAO_Mailing::getPatterns() ? Interesting that the output actually replaced the first Yahoo! (third item) with the second Google URL also.

(Yes, lowercase tags are "more correct", but our staff are already familiar with specific HTML editing tools, and those tools have worked previously to generate mailouts.)

[Chris Burgess]

Interesting ... a second copy of the same mail above I received was like this:

Code: [Select]

<ul>
<li><a href='http://www3.greens.org.nz/sites/all/modules/civicrm/extern/url.php?u=4366&qid=170773'>This link works</a></li>
<li><A href='http://www3.greens.org.nz/sites/all/modules/civicrm/extern/url.php?u=4367&qid=170773'>This link won't</A></li>
<li><A http://www3.greens.org.nz/sites/all/modules/civicrm/extern/url.php?u=4367&qid=170773>This link doesn't</A></li>
<li><a href='http://www3.greens.org.nz/sites/all/modules/civicrm/extern/url.php?u=4366&qid=170773'>This link does</a></li>
</ul>

Same mailout, different recipients ... wierd.

[Chris Burgess]

Opened an issue in JIRA and filed a patch which appears to fix it.

http://issues.civicrm.org/jira/browse/CRM-3484

[pankaj]

Thanks Xurizaemon,

Patch is fine. Commited for 2.1.