Message templates vanish from dropdown -- CivicRM 1.9

[tbruce]

I'm not sure this is an upgrade problem per se -- but it's a bug that's only surfaced since we upgraded.  Message templates are no longer visible in the "Select template" dropdown on the "Send an E-mail" form.  A quick look at the database shows that all templates have the is_active flag set, and we have no trouble creating and storing message templates -- we just can't select or use them.

Any ideas?  They worked fine previously (of course).

Best,
Tb.

[Dave Greenberg]

In 1.9, the message template selector uses a dojo (ajax) widget. You should check how this looks on our demo - and also verify that other ajax widgets on your site are working (the auto-complete contact search in the left column is an example). If not, check your Resource URL setting (Admin CiviCRM >> Global Settings).

If that's not the issue, not sure what to suggest - other than trying to recreate on the 1.9 demo (http://demo.civicrm.org/drupal).

[tbruce]

Autocomplete for searches works fine.  It would appear that ajax is doing something, because the "undefined" text in the subject line comes and goes, and attempts to enter text into the selection menu input box get cleared.  It just seems not to know that the templates exist.  Anyplace I can check a query log, or otherwise look at interaction with the database?

[tbruce]

And another followup:

Manually retrieving the dataurl that the select box is using to provide its values (by pasting it into a browser) does, in fact, get me the templates.  So presumably interaction with the database would be fine, if it were being asked.  I see no problems in the Apache access or error logs.  Next thing is to try restarting the server altogether, mostly as a cargo-cult ritual gesture; maybe something will wash ashore.

[tbruce]

And still more talking to myself:

Something's wrong with the dataurl parameter, I think -- looks like something is putting in an extra escaped ampersand,or else there's a missing key-value pair.  Here's the dataurl value from the message template selection combo box:

dataurl="http://valiant.law.cornell.edu/patron/index.php?q=civicrm/ajax/message&d=1"

And here's the dataurl value from the combo box used by the simple contact search block:

dataUrl="http://valiant.law.cornell.edu/patron/index.php?q=civicrm/ajax/search&d=1&s=%{searchString}"

Note the presence of the slightly mangled escapification of the second ampersand in the message template selection version -- my eyes ran right over it when I was hand-feeding the dataurl to a browser.  Using this dataurl as-is in a browser provokes a message from Drupal but doesn't show up in the apache logs.

I found the relevant template, but since I'm new to all this I have no idea how the template gets filled in with data -- where would we look for this bug?  And is it a missing parameter or is something just getting mangled?  It looks like some kind of silly escapifying problem, or a simple typo.

Help?

[Donald Lobo]

this is now fixed in 1.9 and will be part of the next 1.9 release. You can find the fix here:

http://fisheye.civicrm.org/browse/CiviCRM/branches/v1.9/CRM/Contact/Form/Task/EmailCommon.php?r1=11314&r2=12364

lobo