Paypal Express / Pay later

[bails]

Hi when I enable paypal express as a payment option and also enable a pay later option.  When I test drive or go to the live page and tick "I will pay later" no javascript "continue" button pops up.

I've replicated this on a local sandbox.

Cheers

Bails

[Kurund Jalmi]

Hiding of "PayPal button" when you check Pay Later is intentional. This is done because when you say "Pay Later" you are not doing any payment at that time.

Kurund

[bails]

I can't see where I said "The Paypal button disappears".  In fact it doesn't disappear it still appears (is this another bug?) but there is no "CONTINUE" button hence even though no payment is being made, there is no way to continue to create a membership as there is no button to instigate that action.

Thanks

Bails

[Donald Lobo]

can u replicate this on the demo server, http://drupal.demo.civicrm.org/

i use pay later functionality for all my testing, and it works fine. might want to use firebug and check if there are any js errors with the browser (and hence with our code) etc

lobo

[Kurund Jalmi]

For PayPal Express there is no continue button because you need to click on PayPal button to use Paypal Express and then you will be redirected to PayPal site. If you select Pay Later and you click Paypal Button it will go to next page instead of PayPal site.

HTh
Kurund

[Kurund Jalmi]

I can't see where I said "The Paypal button disappears".  In fact it doesn't disappear it still appears (is this another bug?)

Yes its a bug  filed : http://issues.civicrm.org/jira/browse/CRM-4043

Kurund

[bails]

Ok I've replicated exactly the same behavior on the http://drupal.demo.civicrm.org

What strikes me most is the inconsistency of the 3 paypal options

1. Paypal Express

Why would anyone logically click "I will pay later" then make the thought process go "Oh yes, of course I have to hit the Paypal button to continue"?

2. Paypal Website Standard

It would be really nice if this worked the same as Paypal Pro e.g  a Paypal logo is displayed then you tick "I will pay later" and the paypal logo disappears.

3. Paypal Website Pro

Near enough as perfect as one could get.

Thanks for your help

[Michael McAndrew]

Hi there,

Is there any chance of some pointers on how to fix this bug?  I know that you have filled it as an issue, but we need this for a site that is going live next week 

I've made a start if anyone wants to carry on / chip in.

I presume that somewhere in CRM/Contribute/Form/Contribution/Main.php we need to change the logic of this if statement

Code: [Select]

        // if payment is via a button only, dont display continue
        if ( $this->_paymentProcessor['billing_mode'] != CRM_Core_Payment::BILLING_MODE_BUTTON ||
             ! $this->_values['is_monetary']) {
            // check if button type should be next or upload
            $this->addButtons(array(
                                    array ( 'type'      => $this->buttonType( ),
                                            'name'      => ts('Continue >>'),
                                            'spacing'   => '         ',
                                            'isDefault' => true   ),
                                    )
                              );
        }

and then do a show/hide via jquery on the two options somewhere in the Templates/CRM/Contribute/Form/Contribution/Main.tpl

Am I on the right track?

Michael

[Kurund Jalmi]

Michael,

This is fixed in v2.2 and will be part of next release, you can get the fix from:
http://fisheye.civicrm.org/changelog/CiviCRM/?cs=19627
http://fisheye.civicrm.org/changelog/CiviCRM/?cs=19642

Kurund

[Michael McAndrew]

Great - that is really helpful.  Thanks.