r40475 breaks token replacement - it may break hearts

[ken]

I noticed a problem in 4.1.3 that may represent a lot of broken code.

I noticed that token replacement worked in the Text part of a Scheduled Reminder Email but not the HTML part. See http://forum.civicrm.org/index.php/topic,25025.0.html

I've tracked that down to a change in line 162 of CRM/Utils/Token.php. This change was made as part of r40475 which is a code reformatting change.

My concern is that this might be a symptom of a wide set of unintended changes that will cause all sorts of random havoc.

Here's the change...

Code: [Select]

-        return preg_match("/(^|[^\{])$token/", $str);
+    return preg_match("/(^|[^\{]) $token/", $str);
Note that the indentation has been fixed (good) but a space has been inserted into the regular expression (bad).

I'm assuming this is not an intended consequence of implementing a coding standard.

I suggest this needs an urgent review,

Ken

[ken]

I started looking at the changes made by r40475 and rapidly got daunted.

It just seems a bit odd that a code formatting tool would reach inside a string and change it.

Perhaps the key is to investigate why it did that in this case. That might offer clues about why this happened, and if there is other code effected.

[ken]

BTW I notice the fix for http://issues.civicrm.org/jira/browse/CRM-10389 is due to a similar problem where a PHP string was modified by the code formatter. (The string was Javascript code.)

[Donald Lobo]

Can you please file an issue for this

we'll do a search and check across the entire code base

yeah too bad the coder module did such awful things It was a fairly big commit and we are past the revert stage no

lobo

[Donald Lobo]

filed and fixed here:

http://issues.civicrm.org/jira/browse/CRM-10431

lobo

[ken]

Thanks, Lobo!

How did you review that so promptly? (I'm impressed because the diff file for r40475 was greater than 27Mb! Are you a speed reader? ;-)

Ken

[Donald Lobo]

grep is your friend

i restricted my search to all preg_* functions

lobo