Membership join date incorrectly modified in payment confirmation

[Chris Burgess]

We are seeing a behaviour in 2.0.x and 2.2.3 where a CiviContribute join or renew form will lose membership join dates as a member renews, if they select "Pay later by check". The join date is correct after the renewal, but is changed to the start date when the pending status is updated by the administrator.

For many organisations, this issue will impinge their ability to assess a member's support over time, and is significant for those orgs who restrict members from voting until they have been members for a given period.

This issue is http://issues.civicrm.org/jira/browse/CRM-4523

To reproduce on demo:

0. Configure a CiviContribute renewal page with Pay Later enabled

1. Configure a membership for Tester McTester with join_date and start_date = 2008

view membership details

(http://bushi.net.nz/tmp/membership-details-before-renewal.png)

2. Renew the membership using the CiviContribute page, using "Pay later by check" to set payment = pending

3. Check membership details

view membership details

(http://bushi.net.nz/tmp/membership-details-after-renewal.png)

4. Find membership pending as admin, click "edit" for pending membership

5. Change payment status from Pending to Completed.

When you click Save on this form, the join date for the membership will be set incorrectly.

6. Verify that the join date is now incorrect for this membership. In the image below, the join date has changed from 2008 to 2009.

view membership details

(http://bushi.net.nz/tmp/membership-details-after-payment-confirmed.png)

[Chris Burgess]

I'm not sure why the end date steps back a day at the payment confirmation stage, either, and I'm not sure if that is correct behaviour but I suspect it isn't.

The two year membership may have resulted from me repeating the test, and thus extending the end date to 2010 and then 2011. But we've observed this repeatedly on real registrations (on 2.0 series also) so I'm pretty confident it's not required for the bug to occur.

This issue affects any payment which is confirmed manually - not just pay-by-check. It's just easiest to demonstrate that way

[Chris Burgess]

The original change (SVN r21582) on the related issue CRM-4523 didn't resolve the issue entirely for us - in fact it seemed to be preventing us from updating pending membership contributions.

I've just filed another patch (against v2.2 branch) on that issue.

Note that the official fix is scheduled for 3.0 now, and the code in Contribute/Form/Contribute.php has changed substantially so my patch against v2.2 won't apply against trunk currently. Hopefully this patch should offer a workaround for people on 2.2.

I don't think they are related, but we had some other membership status issues which are documented in http://forum.civicrm.org/index.php/topic,9077.0.html

[Kiran Jagtap]

To exclude pending memberships from $currentMembership array, u can get patch from here : http://forum.civicrm.org/index.php/topic,9077.msg39818.html#msg39818

HTH

kiran