Token processing in CiviContribute Thank You emails

[torenware]

I'm trying to get the token replacement hooks to work with CiviContribute thank-you emails, and AFAICT, token replacement does not yet occur in these emails:  it gets processed directly by Smarty, it appears, without calling the hooks.

Am I correct about this?  And if so, would you folks accept an implementation for 3.0 or soon thereafter?

[torenware]

I'm wondering if the right place to add token processing is around line 1158 in CRM/Contribute/Form/Contribution.php

Code: [Select]

  //send receipt mail.
            if ( $contribution->id && CRM_Utils_Array::value( 'is_email_receipt', $formValues ) ) {
                $formValues['contact_id']      = $this->_contactID;
                $formValues['contribution_id'] = $contribution->id;
                $sendReceipt = CRM_Contribute_Form_AdditionalInfo::emailReceipt( $this, $formValues );
            }

acting upon $formValues, or within CRM_Contribute_Form_AdditionalInfo::emailReceipt().  The format of the argument to the token hooks is not exactly the same, so I'd have to pack it up and unpack it, but it looks like the right place to do this.

[Donald Lobo]

So none of the receipt code (contribution or event reg) does any token substitution. I would probably do all the token evaluation in the emailReceipt function. I'd also do the same for event registration

Since 3.0 is on its way out, i suspect this will make it into core in 3.1 or so

lobo