CiviCRM Community Forums (archive)

also, this file: civicrm_handler_field_custom.inc seems to be only about activities? Should it be renamed?

I'm going to leave it there for the moment - I'm just confusing myself and not really helping.

Thanks for replying Michael

I think the problem is likely to be that the handlers haven't been written for activity custom fields.

Something strange just happened:

decided to test across civi data and their types

created the following custom data sets:

Name	Used For	Type
contact_test	All Contact Types	Any
activity_any_test	Activities	Any
activity_meeting_test	Activities	Meeting
event_any_test	Events	Any
event_conference_test	Events	Conference

Without adding anything to settings.py settings.php, I went to views->list and chose to edit the view I'm struggling with.

Add a field, and "CiviCRM Custom: activity_any_test" appears. Despite not being added to settings.py settings.php

I am going to add all of the tables to settings now to see which others appear or don't appear.

=== Results ===

After adding the 5 Custom data sets listed above to settings.php, when creating views that apply to each data type, the results are:

Name	Used For	Type	Did it appear?
contact_test	All Contact Types	Any	YES
activity_any_test	Activities	Any	YES
activity_meeting_test	Activities	Meeting	NO
event_any_test	Events	Any	YES
event_conference_test	Events	Conference	NO

I guess the thing I'm struggling with here is that there are "types" of Activities and Events (email, phone call, conference, meeting), but the Contact isn't typed. IE, I know there's a problem with the rendering of subtyped types, but I have nothing to measure the code...will keep searching.

1. i suspect your civicrm and drupal db are the same. in which case you dont need to add anything in settings.php

No, they are different.

2. as mentioned in IRC, your best bet is to add some debugging code to:

civicrm_views_custom_data_cache in drupal/modules/views/civicrm.views.inc

that will probably give you an idea as to why those tables are not exposed to views

Yep, looking into it now, thanks.

3. if a contact is not typed, it applies to all contacts (note that there is just one civicrm_contact table), so basically that is exposed

lobo

thanks...

ok, this file: civicrm_handler_filter_activityType.inc references State/Province:

39     function title( ) {
40         return t('State/Province');
41     }

which seems weird to me? I don't even know if this is where the problem is - I was just reading the source.

fixed for 3.2

lobo

Hoopla! We have a winner!

Ok, so it goes like this:

1. Complain a lot on forums and irc. Until someone pays attention, dlobo and eileen, cheers cheers to dlobo and eileen for answering my incessant questions.
2. As requested, debug via civicrm.views.inc, looking at the function: civicrm_views_custom_data_cache
3. Don't know where to start, try by outputting values to see if they match expectations. Add code at 4730-4732 as per:

4726     else {
4727         $tree = CRM_Core_BAO_CustomGroup::getTree( $entity_type, CRM_Core_DAO::$_nullObject, null, $groupID);
4728     }
4729
4730 /*   echo "entity type  = $entity_type ||\n";
4731  *   echo "subtype = $subType ||\n";
4732  *   echo "GroupID = $groupID ||";
4733  */
4734     switch ($entity_type) {

4. See output is as expected. Well, as much as I know what to expect. See first attachement "first_debug_attempt.png". In particular, we can see that my activity with subtypes (group id 6, cut off in pic) exists, and those subtypes are listed (23, 1, 24, 2, 25)

5. Jump down a  few lines to within the foreach loop and try again:


4765         $data[$currentgroup['table_name']]['table']['group']  = t('CiviCRM Custom: ') . $currentgroup['title'];
4766
4767         echo $currentgroup['title'];
4768         echo " | ";
4769         // Join this table to Contacts

6. Do not see the expected output. Again, as much as I know. See "second_debug_attempt.png" attachment. "test" and "pf_testy" is my test custom data set, with subtype "Any" selected instead of a specific or group of specific, subtypes. None of the Activities with a selective subtype list appear.

7. Hence, problem exists between line 4732 and 4767. I think. Since I don't really know the code, I'm working on this hypothesis for the moment.

8. What's in there? Let's see:
4730 /*   echo "entity type  = $entity_type ||\n";
4731  *   echo "subtype = $subType ||\n";
4732  *   echo "GroupID = $groupID ||";
4733  */
4734     switch ($entity_type) {
4735
4736     case "Contact":
4737     case "Individual":
4738     case "Household":
4739     case "Organization":
4740         $jointable = 'civicrm_contact';
4741         break;
4742     case "Event":
4743         $jointable = 'civicrm_event';
4744         break;
4745     case "Participant":
4746         $jointable = 'civicrm_participant';
4747         break;
4748     case "Contribution":
4749         $jointable = 'civicrm_contribution';
4750         break;
4751     case "Activity":
4752         $jointable = 'civicrm_activity';
4753         break;
4754     case "Relationship":
4755         $jointable = 'civicrm_relationship';
4756         break;
4757     case "Membership":
4758         $jointable = 'civicrm_membership';
4759         break;
4760     }
4761
4762     foreach ($tree as $groupkey => $currentgroup) {
4763         if ($groupkey == 'info') { return $data; } // dodges an invalid argument call after all the groups go through // have a look at what $tree outputs to to see why.
4764
4765         $data[$currentgroup['table_name']]['table']['group']  = t('CiviCRM Custom: ') . $currentgroup['title'];
4766
4767         echo $currentgroup['title'];
4768         echo " | ";

9. Lines 4734 through to 4760 are just a switch statement, ignore

10. 4762 uses this $tree var. What is that? ....looks like it's set above the first debug lines:
  4722     if ($style == 'Inline') {
   4723         //echo "subtype = $subType --";
   4724         $tree = CRM_Core_BAO_CustomGroup::getTree( $entity_type, CRM_Core_DAO::$_nullObject, null, $groupID, $subType, null);
   4725     }
   4726     else {
   4727         $tree = CRM_Core_BAO_CustomGroup::getTree( $entity_type, CRM_Core_DAO::$_nullObject, null, $groupID);
   4728     }

11. As you can see, I put in another debug statement, and again got the correct answer. I also think that I may have changed the "inline" (all my data types are inline) call to CRM_Core_BAO_CustomGroup::getTree to include either $subType or $groupID - I'm pretty sure one of them was set to null (why??).

12. Time to go looking for CRM_Core_BAO_CustomGroup::getTree (meanwhile thinking, surely the problem is in views, not in BAO....)

13. Find getTree, find if ( $subType ):
327         if ( $subType ) {
    328             $subType  = CRM_Core_DAO::VALUE_SEPARATOR . $subType . CRM_Core_DAO::VALUE_SEPARATOR;
    329             $strWhere = "
    330 WHERE civicrm_custom_group.is_active = 1
    331   AND civicrm_custom_field.is_active = 1
    332   AND civicrm_custom_group.extends IN ($in)
    333   AND ( civicrm_custom_group.extends_entity_column_value LIKE '%$subType%'
    334    OR   civicrm_custom_group.extends_entity_column_value IS NULL )
    335 ";
    336             if ( $subName ) {
    337                 $strWhere .= " AND civicrm_custom_group.extends_entity_column_id = {$subName} ";
    338             }
    339         } else {

14. Start to cry at the wormhole opening before me. Go looking for what the hell CRM_Core_DAO::VALUE_SEPARATOR is.

15. Dr Google tells me that there's a post on the Forums about this: http://forum.civicrm.org/index.php?topic=11654.0

16. Read post, comment out line 321 as suggested (except for me that line is 328, see above)

17. Reload Views edit page and whoop! there it is, my custom type sitting there pretty. Haven't done any testing to see what i've broken yet - came here first.  Will be in IRC all day and all tomorrow.

I didn't see the second page of the forum post I listed above (to my shame), dlobo was kind enough to point it out:

http://forum.civicrm.org/index.php/topic,11654.msg51738.html#msg51738

Unfortunately, it didn't work:
Database changed
mysql> UPDATE civicrm_custom_group SET extends_entity_column_value = CONCAT(CHAR( 01 ), extends_entity_column_value, CHAR( 01 )) WHERE LOCATE( char( 01 ), extends_entity_column_value ) <= 0;
Query OK, 0 rows affected (0.00 sec)
Rows matched: 0  Changed: 0  Warnings: 0


When I uncommented line 328, I could no longer access the data in views...