CiviCRM Community Forums (archive)

*

News:

Have a question about CiviCRM?
Get it answered quickly at the new
CiviCRM Stack Exchange Q+A site
This forum was archived on 25 November 2017. Learn more.
How to get involved.
What to do if you think you've found a bug.



  • CiviCRM Community Forums (archive) »
  • Old sections (read-only, deprecated) »
  • Support »
  • Using CiviCRM »
  • Using CiviContribute »
  • Community Contributed Payment Processors »
  • Core/Payment/IATS.php code bugs/fixes
Pages: 1 2 [3]

Author Topic: Core/Payment/IATS.php code bugs/fixes  (Read 10512 times)

adixon

  • I post frequently
  • ***
  • Posts: 314
  • Karma: 19
    • Blackfly Solutions
Re: Core/Payment/IATS.php code bugs/fixes
September 04, 2014, 02:28:17 pm
I'm a little confused because you've posted this in a thread about the old iATS payment processor, which is a different beast than the new one.

Which one are you talking about?

If you're talking about the new one, then all I can say is that the doDirectPayment for a recurring payment does process straight away. Whether that's triggered via a membership or not shouldn't make a difference as far as the code goes.

Eileen

  • Forum Godess / God
  • I’m (like) Lobo ;)
  • *****
  • Posts: 4195
  • Karma: 218
    • Fuzion
Re: Core/Payment/IATS.php code bugs/fixes
September 04, 2014, 02:30:05 pm
Yes - I am working with the new one - what we are seeing is that doDirectPayment is called but CiviCRM does not update the membership because it has code that specifically says 'if this is recurring & we are using a direct type payment processor then don't update the membership'

Make today the day you step up to support CiviCRM and all the amazing organisations that are using it to improve our world - http://civicrm.org/contribute

Eileen

  • Forum Godess / God
  • I’m (like) Lobo ;)
  • *****
  • Posts: 4195
  • Karma: 218
    • Fuzion
Re: Core/Payment/IATS.php code bugs/fixes
September 04, 2014, 02:32:29 pm
NB - I've dealt with 2 other payment processors with Recurring memberships - eWay & Authorize.net & neither of them process the initial transaction immediately - so the flow works for them (probably because that is the way Authorize.net naturally works & by good luck or drawn-out-troublehooting eWay is using a delayed pattern too)
Make today the day you step up to support CiviCRM and all the amazing organisations that are using it to improve our world - http://civicrm.org/contribute

adixon

  • I post frequently
  • ***
  • Posts: 314
  • Karma: 19
    • Blackfly Solutions
Re: Core/Payment/IATS.php code bugs/fixes
September 04, 2014, 02:37:25 pm
Ah okay - so your core code update is likely the right answer for the longer term, though it's kind of nasty that such an assumption is built-into the code in the first place ...

The way I've overcome this issue in core for the contribution itself is via a post hook. Something similar is probably what I'd need to do for memberships to support the existing codebase.

Eileen

  • Forum Godess / God
  • I’m (like) Lobo ;)
  • *****
  • Posts: 4195
  • Karma: 218
    • Fuzion
Re: Core/Payment/IATS.php code bugs/fixes
September 04, 2014, 02:43:24 pm
OK - I'll patch our repo with that for now & log a ticket / do a PR - although I don't expect it to go into core without a fairly careful set of extra eyes on the code
Make today the day you step up to support CiviCRM and all the amazing organisations that are using it to improve our world - http://civicrm.org/contribute

Eileen

  • Forum Godess / God
  • I’m (like) Lobo ;)
  • *****
  • Posts: 4195
  • Karma: 218
    • Fuzion
Re: Core/Payment/IATS.php code bugs/fixes
September 15, 2014, 08:53:16 am
After some more digging ... it seems that Authorize.net correctly doesn't set trxn_id - which is used elsewhere to denote success -

so I'm anticipating

https://github.com/eileenmcnaughton/civicrm-core/compare/civicrm:4.4...eileenmcnaughton:CRM-15296-44?expand=1

although I'll do some more testing tomorrow
Make today the day you step up to support CiviCRM and all the amazing organisations that are using it to improve our world - http://civicrm.org/contribute
Pages: 1 2 [3]
  • CiviCRM Community Forums (archive) »
  • Old sections (read-only, deprecated) »
  • Support »
  • Using CiviCRM »
  • Using CiviContribute »
  • Community Contributed Payment Processors »
  • Core/Payment/IATS.php code bugs/fixes

This forum was archived on 2017-11-26.