CiviCRM Community Forums (archive)

I knew that someone would respond to Speleo with the two default OSS answers (do it or pay someone to do it).  Lobo do you have a document with default answers that you just copy and paste from?   

nope. it would be at least 50 hours, IMO

lobo

I really need this functionality but would like it in the stable version.  It feels as if CiviMember hasn't been updated for years and is lacking now. This would be a major step forward for folks managing complex membership levels.

Would it be hard to get this in core?

Lobo estimated it as a 75-100 hour project when we discussed this previously here.

However if the patch mentioned above works maybe it's a bit smaller project--I'd be interested to hear what the developers might have to say.  I would assume there is some reason why they didn't implement the fairly simple solution in the patch in the first places--maybe there are edge cases where it doesn't work, or maybe it would simply take a lot of testing to make sure it really does work & they just didn't have time for that at the time.

At any rate, I'd also be very interested in this feature.

Top stuff. Please keep us informed of how it goes as I'm following with a lot of interest.

Cheers, Speleo

By the way, if we were to accept jalama's idea as a reasonable way to address this issue of combining membership payments & price sets, then this module has almost all of the implementation worked out.

How this would look if it were integrated into the code (rather than as a module):

 - Every Price Set would have a hidden field which will hold the membership total amount if memberships are included in the contribution page and the user selects one.

 - Change the contribution admin pages so that both memberships & price sets can be selected simultaneously without creating an error.

(The above two are the only two issues that the module or included files doesn't have completely worked out.)

 - selectMembership elements would need a 'price' attribute added, similar to the ones Price Fields have (see member_pricesets.module lines 81-95).

 - After the form has been submitted, copy the membership price to the special Price Field (similar to member_pricesets.module lines 136-146).

 - Update CRM/Contribute/Form/Contribution/Main.tpl to allow both memberships & price sets to be visible (see Main.tpl about line 65).

 - Update CRM/Member/BAO/Membership.php so that memberships and price sets can both be displayed on the receipts (about 4 lines of code, see Membership.php about line 1145).

 - Fix a couple of bugs in CRM/Contribute/Form/Contribution/ThankYou.php (see ThankYou.php about line 131 and line 152).

 - Incorporate the email receipt templates included in this module--they allow for both membership info & Price Sets to be displayed and rearrange things just slightly so that the receipts make sense with either or both of those options displayed.
  
That's pretty much it.

flug,

Thanks for this - what a great help!

I have followed the readme file step by step as well as your directions here in the forum and believe I have everything set up as directed. However, I'm getting an error message I haven't been able to track down and solve.

The error message displays after I have copied the Main.tpl file into the custom templates directory (custom_templates/CRM/Contribute/Form/Contribution/). Before adding the custom Main.tpl file, the Membership Renewal form displays only the price set and not the Membership types (as expected from your earlier note).

I've tried implementing the module three times and get the same result every time so decided it was time to ask for help.

The error message says:
Database Error Code: You have an error in your SQL syntax;
check the manual that corresponds to your MySQL server version
for the right syntax to use near ':5:{i:20;N;i:1;N;i:4;N;i:2;N;i:6;N;} )'
at line 3, 1064

Additional Details:

Array
(
    [callback] => Array
        (
            [0] => CRM_Core_Error
            [1] => handle
        )

    [code] => -2
    [message] => DB Error: syntax error
    [mode] => 16
    [debug_info] =>
SELECT *
FROM   civicrm_membership_type
       WHERE id IN ( a:5:{i:20;N;i:1;N;i:4;N;i:2;N;i:6;N;} );
 [nativecode=1064 ** You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ':5:{i:20;N;i:1;N;i:4;N;i:2;N;i:6;N;} )' at line 3]
    [type] => DB_Error
    [user_info] =>
SELECT *
FROM   civicrm_membership_type
       WHERE id IN ( a:5:{i:20;N;i:1;N;i:4;N;i:2;N;i:6;N;} );
 [nativecode=1064 ** You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ':5:{i:20;N;i:1;N;i:4;N;i:2;N;i:6;N;} )' at line 3]
    [to_string] => [db_error: message="DB Error: syntax error" code=-2 mode=callback callback=CRM_Core_Error::handle prefix="" info="
SELECT *
FROM   civicrm_membership_type
       WHERE id IN ( a:5:{i:20;N;i:1;N;i:4;N;i:2;N;i:6;N;} );
 [nativecode=1064 ** You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ':5:{i:20;N;i:1;N;i:4;N;i:2;N;i:6;N;} )' at line 3]"]
)


The "a:5:{i:20;N;..." in the error message is the content of the membership_types field in the civicrm_membership_block table in MySQL. It was created by CiviCRM when I created the membership types and I have not edited the field directly in the database so I don't know why there would be an error.

I don't know what "line 3, 1064" refers to.

Is this really a MySQL error or is it an error in some code that is calling that field in the database? Is there something I was supposed to edit in the Main.tpl file? I'm puzzled as to where to look for the source of the error and how to fix it. Any ideas?

Many thanks to you, jalama, and Brent for the code and instructions! I have high hopes for a successful implementation if I can get over this error message hump.

Thanks,
Michael

After lots more testing and adding and removing things one at a time, here's what I found.

The Database Error I received earlier is eliminated when I delete the custom Membership.php that comes with the module.

Without the custom Membership.php, the Membership/Renewal form displays both the Membership types and the Price Set (hooray!) and is fairly functional. I am able to add a new member, select a membership level and a Price Set item, and the correct total displays in the Total Fees field.

When I click "Continue" to confirm the contribution, the Thank you page displays, but I get a warning:
warning: in_array() [function.in-array]:
Wrong datatype for second argument in
.../custom_php/CRM/Contribute/Form/Contribution/ThankYou.php
on line 134.
The email receipt is sent and lists both the Membership fee and the Price Set item fee (although the Membership fee says Qty: 100.00, Unit Price: $1.00, Total Price: $100.00).

As soon as I re-upload the custom Membership.php file, I get the Database Error I reported earlier.

Any suggestions on editing the ThanKYou.php and/or Membership.php or doing something else to resolve this? I poked around the code, but didn't dare change anything without further advice.

Thanks!
 Michael