CiviCRM Community Forums (archive)

Pat - Since I hadn't used this hook before, I did my own experiment (on my 3.2 sandbox). It worked fine for me - I modified the fees for two of the "sample" membership types ("General" and "Student"). I've attached a screenshot of the confirmation page - showing the modified fee of $5.55.

There is a logic error in the 'for' loop in your code  - which I think might be causing some confusion. The membershipTypeValues array is indexed starting at 1, not 0. Compare to my code below.

function dgg_civicrm_membershipTypeValues( &$form, &$membershipTypeValues ) {
    for ($i=1; $i <= count($membershipTypeValues); $i++) {
      if ($membershipTypeValues[$i]['name'] == 'General') {
          $membershipTypeValues[$i]['minimum_fee'] = "5.55";
      }
      if ($membershipTypeValues[$i]['name'] == 'Student') {
          $membershipTypeValues[$i]['minimum_fee'] = "2.22";
      }
    }       
}

TIP: when you're working with CiviCRM code, it's often useful to dump one or more variable / array / objects to the screen. Use:

CRM_Core_Error::debug('label', $varOrArrayToDump);
Regarding "am I approaching this right" .... I would say yes (for now). Your other option is to get this functionality added to core behaviors by flushing out the specifications for configuring renewal pricing and behaviors and contributing patches to the core to make it happen (or sponsoring / funding the work).

Pat - No attachment, my sample code was inline in previous post.

Your 'for' statement still has an error - which "might" be causing the problem ?? Should be:
for ($i=1; $i <= count($membershipTypeValues); $i++) {

(less than or equal to, rather than less than)

If the module is effecting the page (i.e. initial prices are correctly adjusted) - and the above change doesn't fix things - then I'd recommended upgrading to 3.2 beta 3 which is where I did my "experiment". (I say this under assumption that you're not doing this on a production site.)

Ahh yes - that attachment :-) Here it is...

Arrgh. You're right - selecting the 2nd membership type ('Student' in may case) fails. :-(

I've filed an issue in the bug tracker:
http://issues.civicrm.org/jira/browse/CRM-6479

I verified that Kurund's approach (using foreach looping) works with my example and I've closed the issue.

function mymodule_civicrm_membershipTypeValues( &$form, &$membershipTypeValues ) {
    foreach ( $membershipTypeValues as &$values) {
          if ( $values['name'] == 'General') {
              $values['minimum_fee'] = "5.55";
          }
          if ( $values['name'] == 'Student') {
              $values['minimum_fee'] = "2.22";
          }
    }
}


OK, I have learnt a lot, but I would like someone to cast their eyes over this to make sure it is all good:

<?php

membershipRenewalContentArray;

   require_once ('/home/humanmil/public_html/drupal/sites/all/civicrm.settings.php');
   require_once ($civicrm_root . '/CRM/Core/Config.php'); 
   $config =& CRM_Core_Config::singleton( );
   
   require_once "api/v2/Contribute.php";
   require_once "api/v2/Membership.php";


// reduce the price of renewals by the value set in the admin control
function membershipRenewal_civicrm_membershipTypeValues( &$form, &$membershipTypeValues ) {

  // get all memberships
  $membershipTypes = _civimember_roles_get_data('types');

  // loop through the membership array and fetch renewal values
    foreach ( $membershipTypeValues as &$values) {
    
      // loop through membership types
      for ($i=1; $i<=count($membershipTypes); $i++) {
      
        // find membership type in array
        // if a renewal fee exists, use that. Otherwise use the full fee
        if (array_search($values['name'], $membershipTypes[$i])) {
          $fieldName = "membershipRenewal_" . str_replace(" ", "_", $membershipTypes[$i][1]);
            $values['minimum_fee'] = variable_get($fieldName, $membershipTypes[$i][2]);
  
        } 
      }
   
    }
       
}



// admin control panel
function membershipRenewal_admin() {

  // get all membership types
  $membershipTypes = _civimember_roles_get_data('types');

  // loop through membership types, and create a field to add a renewal price
  for ($i=1; $i<=count($membershipTypes); $i++) {
      $fieldName = "membershipRenewal_" . str_replace(" ", "_", $membershipTypes[$i][1]);
      $form[$fieldName] = array(
        '#type' => 'textfield',
        '#title' => t('Renewal price of <i>' . $membershipTypes[$i][1] . '</i> (new membership is $' . $membershipTypes[$i][2] . ')'),
        '#default_value' => variable_get($fieldName, $membershipTypes[$i][2]),
        '#size' => 2,
        '#maxlength' => 5,
        '#description' => t("Price to renew"),
        '#required' => TRUE,
      );  
    }

  // return the form
  return system_settings_form($form);
}


// validate admin input
function membershipRenewal_admin_validate($form, &$form_state) {
  
  // todo: validate input
 
}


// display link in module menu
function membershipRenewal_menu() {

  $items = array();

  $items['admin/settings/membershipRenewal'] = array(
    'title' => 'Membership Renewal Settings',
    'description' => 'Setting for when subscribers renew their memberships',
    'page callback' => 'drupal_get_form',
    'page arguments' => array('membershipRenewal_admin'),
    'access arguments' => array('access administration pages'),
    'type' => MENU_NORMAL_ITEM,
   );

  return $items;
}




// define access permissions
function membershipRenewal_perm() {
  return array('access membershipRenewal content');
} 



/**
 * This function returns an array of either membership types or status rules depending on the $type param.
 * Function is from civimember_roles module
 */
function _civimember_roles_get_data($type) {
  switch ($type) {
    case 'status':
      $sql = 'SELECT id, name FROM civicrm_membership_status WHERE domain_id = %1;';
      break;
      
    case 'types':
      $sql = 'SELECT id, name, minimum_fee FROM civicrm_membership_type WHERE domain_id = %1;';
      break;
      
    default:
      $sql = '';
      drupal_set_message(t('Invalid parameter was given to _civimember_roles_get_data(). Param: "%invalid".', array('%invalid' => $type)));
      break;
  }

  $params = array(1 => array(CIVICRM_DOMAIN_ID, 'Integer'));
  $dao =& CRM_Core_DAO::executeQuery($sql, $params);
  
  $result = array();
  while ($dao->fetch()) {
    $result[$dao->id] = array($result[$dao->id], $dao->name, $dao->minimum_fee); 
  }
  
  unset($dao);
  
  if (empty($result)) {
    drupal_set_message(t('CiviMember Membership Types or Status Rules have not been configured. Please do so on the "Administer CiviCRM" page.'), $type = 'error');
  }
  
  return $result;
}
I have pulled bits of code from here and there, and put it together.  What it does is allow you to create a discounted price for all memberships. If a user is a subscriber, it displays the renewal price. If they are not a subscriber, then it shows the price for a new subscription.

I am sure this will not be for everyone, but it fits pretty well with what we need. Now the next step will be to extend the current subscription expiry date, rather than creating a new subscription... It doesn't seem as daunting as it did before...

function membershipRenewal_civicrm_postProcess( $formName, &$form ) {
   if ( is_a( $form, 'CRM_Contribute_Form_Contribution_Main' ) ) {
    CRM_Core_Error::debug('form values', $form->_values); 
   }
}

this is because _values is a public variable, in case it was protected, the below code (which is pretty crude but works) would suffice:

function membershipRenewal_civicrm_postProcess( $formName, &$form ) {
   if ( is_a( $form, 'CRM_Contribute_Form_Contribution_Main' ) ) {
    CRM_Core_Error::debug('form values', $form->getVar('_values')); 
   }
}

lobo

not sure if that would work, but this would work:

  $values = $form->getVar( '_values' );
  $values['foo'] = 'bar';
  $form->setVar( '_values', $values );

lobo